update CI actions, lint and lint config

.github/workflows/build-binary-package.yml

@@ -20,12 +20,12 @@ jobs:
     steps:
 
     - name: Check out repository
-      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
       with:
         fetch-depth: 0
 
     - name: Set up Go
-      uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+      uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
       with:
         go-version-file: go.mod
 

.github/workflows/lint.yml

@@ -17,17 +17,17 @@ jobs:
 
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
         with:
           fetch-depth: 0
 
       - name: Set up Go
-        uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
         with:
           go-version-file: go.mod
 
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@f443b600d91635bebf5b0d9ebc620189c0d6fba5 # v4.30.8
+        uses: github/codeql-action/init@cf1bb45a277cb3c205638b2cd5c984db1c46a412 # v4.31.7
         with:
           languages: go, python
 
@@ -36,11 +36,11 @@ jobs:
           make build
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
+        uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0
         with:
-          version: v2.5
+          version: v2.7
           args: --issues-exit-code=1 --timeout 10m
           only-new-issues: false
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@f443b600d91635bebf5b0d9ebc620189c0d6fba5 # v4.30.8
+        uses: github/codeql-action/analyze@cf1bb45a277cb3c205638b2cd5c984db1c46a412 # v4.31.7

.github/workflows/tests.yml

@@ -17,12 +17,12 @@ jobs:
     steps:
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
       with:
         fetch-depth: 0
 
     - name: Set up Go
-      uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+      uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
       with:
         go-version-file: go.mod
 
@@ -39,14 +39,14 @@ jobs:
         RICHGO_FORCE_COLOR: 1
 
     - name: Install uv
-      uses: astral-sh/setup-uv@3259c6206f993105e3a61b142c2d97bf4b9ef83d # v7.1.0
+      uses: astral-sh/setup-uv@ed21f2f24f8dd64503750218de024bcf64c7250a # v7.1.5
       with:
         version: 0.5.24
         enable-cache: true
         cache-dependency-glob: "test/uv.lock"
 
     - name: "Set up Python"
-      uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
+      uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
       with:
         python-version-file: "test/.python-version"
 

.github/workflows/tests_deb.yml

@@ -17,24 +17,24 @@ jobs:
     steps:
 
     - name: Check out code into the Go module directory
-      uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
       with:
         fetch-depth: 0
 
     - name: Set up Go
-      uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+      uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
       with:
         go-version-file: go.mod
 
     - name: Install uv
-      uses: astral-sh/setup-uv@3259c6206f993105e3a61b142c2d97bf4b9ef83d # v7.1.0
+      uses: astral-sh/setup-uv@ed21f2f24f8dd64503750218de024bcf64c7250a # v7.1.5
       with:
         version: 0.5.24
         enable-cache: true
         cache-dependency-glob: "test/uv.lock"
 
     - name: "Set up Python"
-      uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
+      uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
       with:
         python-version-file: "test/.python-version"
 

.golangci.yml

@@ -8,7 +8,9 @@ linters:
     - gocognit  # revive
     - gocyclo   # revive
     - lll       # revive
+    - wsl       # wsl_v5
 
+    - depguard
     - dupl
     - err113
     - exhaustruct
@@ -27,21 +29,13 @@ linters:
     - varnamelen
     - whitespace
     - wrapcheck
-    - wsl
     - funcorder
     - wsl_v5
     - noinlineerr
     - noctx
     - godoclint
   settings:
 
-    depguard:
-      rules:
-        main:
-          deny:
-            - pkg: github.com/pkg/errors
-              desc: errors.Wrap() is deprecated in favor of fmt.Errorf()
-
     errcheck:
       check-type-assertions: false
 
@@ -62,6 +56,10 @@ linters:
     misspell:
       locale: US
 
+    modernize:
+      disable:
+        - stringsseq
+
     nestif:
       # lower this after refactoring
       min-complexity: 13
@@ -142,8 +140,8 @@ linters:
         text: 'shadow: declaration of "(err|ctx)" shadows declaration'
 
       - linters:
-          - perfsprint
-        text: fmt.Sprintf can be replaced .*
+          - revive
+        text: 'deep-exit: calls to flag.Parse only in main\(\) or init\(\) functions'
     paths:
       - third_party$
       - builtin$
@@ -154,6 +152,10 @@ issues:
   max-same-issues: 0
 
 formatters:
+  enable:
+    - gci
+    - gofumpt
+
   settings:
     gci:
       sections:

pkg/cfg/config.go

@@ -8,8 +8,8 @@ import (
 	log "github.com/sirupsen/logrus"
 	"gopkg.in/yaml.v2"
 
-	"github.com/crowdsecurity/go-cs-lib/ptr"
 	"github.com/crowdsecurity/go-cs-lib/csyaml"
+	"github.com/crowdsecurity/go-cs-lib/ptr"
 )
 
 type PrometheusConfig struct {

pkg/iptables/iptables_stub.go

@@ -1,5 +1,4 @@
 //go:build !linux
-// +build !linux
 
 package iptables
 

pkg/nftables/metrics.go

@@ -7,11 +7,10 @@ import (
 	"strings"
 	"time"
 
-	"github.com/prometheus/client_golang/prometheus"
-	log "github.com/sirupsen/logrus"
-
 	"github.com/google/nftables"
 	"github.com/google/nftables/expr"
+	"github.com/prometheus/client_golang/prometheus"
+	log "github.com/sirupsen/logrus"
 
 	"github.com/crowdsecurity/cs-firewall-bouncer/pkg/metrics"
 )

pkg/nftables/nftables_stub.go

@@ -1,5 +1,4 @@
 //go:build !linux
-// +build !linux
 
 package nftables