Expiring lock stores & lock's TTL fixes #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Please do |
G81BVfaN
force-pushed
the
expiring_lock_stores_fix
branch
from
be85011 to
cb4e1b8
Compare
Author
|
Done, but the |
G81BVfaN
force-pushed
the
expiring_lock_stores_fix
branch
from
cb4e1b8 to
4004aba
Compare
Author
Rookie mistake, i rebased with our fork's origin, instead of the upstream's origin 😅 |
src/Event.php
Outdated
| * @throws CrunzException | ||
| */ | ||
| public function preventOverlapping(?object $store = null) | ||
| public function preventOverlapping(?object $store = null, ?int $ttl = 30) |
| $this->skip(function () { | ||
| $lock = $this->createLockObject(); | ||
| $this->skip(function () use ($ttl) { | ||
| $lock = $this->createLockObject($ttl); |
Author
There was a problem hiding this comment.
I've added a very basic test:
test_expiring_store_can_be_passed_to_prevent_overlapping_with_ttl()
G81BVfaN
force-pushed
the
expiring_lock_stores_fix
branch
from
e6ebec0 to
487a9c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.