Merged
Conversation
Member
smessmer
commented
Jan 10, 2026
smessmer
commented
- Add Jest and React Testing Library for unit/component tests
- Add Playwright for E2E tests
- Create colocated test files for components:
- Utility tests: Timeout, Defer, RoutingListener
- Core components: AsyncButton, Console, AlternatingSections, MetaTags, Layout
- Form components: NewsletterSection, ContactSection
- Modal components: RouteHashBasedModal, Download
- Add E2E tests for user flows:
- Homepage, navigation, newsletter signup
- Contact form, download modal, comparison page
- Add mock files for Next.js router, Link, Head, Script
- Add mocks for aphrodite, unfetch
- Update README with testing instructions
- Update CI workflow to run unit and E2E tests before build
- Add Jest and React Testing Library for unit/component tests - Add Playwright for E2E tests - Create colocated test files for components: - Utility tests: Timeout, Defer, RoutingListener - Core components: AsyncButton, Console, AlternatingSections, MetaTags, Layout - Form components: NewsletterSection, ContactSection - Modal components: RouteHashBasedModal, Download - Add E2E tests for user flows: - Homepage, navigation, newsletter signup - Contact form, download modal, comparison page - Add mock files for Next.js router, Link, Head, Script - Add mocks for aphrodite, unfetch - Update README with testing instructions - Update CI workflow to run unit and E2E tests before build
Only the deploy job now waits for all three to complete. This speeds up CI by not blocking build on test completion.
- Exclude test files, e2e tests, and jest config from main tsconfig - Create tsconfig.jest.json for Jest TypeScript configuration - Add jest.d.ts for jest-dom matcher types - Add *.tsbuildinfo to gitignore
- Use .first() for selectors that may match multiple elements - Scope selectors to specific containers (modal, footer, table) - Use role-based selectors for tab navigation in download modal - Fix contact form, comparison page, download modal, homepage, and navigation tests
- Replace getByRole('tab') with locator('.nav-tabs').getByText() since
Reactstrap NavLink doesn't use role="tab"
- Use getByRole('heading') for h3 headings like 'Easy Install', 'Mac OS X',
'Windows'
- Scope all selectors properly to avoid strict mode violations
E2E tests were causing CI failures due to strict mode violations. Removing them for now to be added back later. - Remove e2e/ directory and playwright.config.ts - Remove @playwright/test dependency - Remove test:e2e scripts from package.json - Remove e2e job from CI workflow - Update README to remove E2E testing documentation
smessmer
force-pushed
the
claude/add-frontend-tests-D27G1
branch
3 times, most recently
from
7cb54a7 to
318a83b
Compare
smessmer
force-pushed
the
claude/add-frontend-tests-D27G1
branch
from
318a83b to
7cbb579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.