fix: ensure tools can load datasets that are exactly 4kiB#124
Merged
nfrasser merged 4 commits intorelease-v4.7from Mar 4, 2025
Merged
fix: ensure tools can load datasets that are exactly 4kiB#124nfrasser merged 4 commits intorelease-v4.7from
nfrasser merged 4 commits intorelease-v4.7from
Conversation
This must work on linux
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Also ensures empty datasets exactly 4kiB don't fail on linux
hsnyder
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found an issue where datasets of this file size fail to load due to a bug in numpy < 2.2. Appears to be related to page size on linux.
See numpy/numpy#27723 (released in 2.2, but we have to support older versions)