feat(discovery): implement All Namespaces discovery#213
Merged
andrewazores merged 15 commits intocryostatio:mainfrom Jun 12, 2025
Merged
feat(discovery): implement All Namespaces discovery#213andrewazores merged 15 commits intocryostatio:mainfrom
andrewazores merged 15 commits intocryostatio:mainfrom
Conversation
7 tasks
tthvo
reviewed
Nov 30, 2024
Member
tthvo
left a comment
There was a problem hiding this comment.
I agree with cryostatio/cryostat-operator#976 (comment) here, this might introduce more elevated access than intended.
Contributor
|
Needs to be rebased, there are a few conflicts to resolve |
26cc9d2 to
53958f7
Compare
tthvo
reviewed
May 8, 2025
tthvo
reviewed
May 9, 2025
Member
tthvo
left a comment
There was a problem hiding this comment.
Looks good to me!
I guess we will need to adjust rule for clusterrole after cryostatio/cryostat#740 :D
Co-authored-by: Thuan Vo <thvo@redhat.com> Signed-off-by: Andrew Azores <me@andrewazor.es>
Co-authored-by: Thuan Vo <thvo@redhat.com> Signed-off-by: Andrew Azores <me@andrewazor.es>
Co-authored-by: Thuan Vo <thvo@redhat.com> Signed-off-by: Andrew Azores <me@andrewazor.es>
66e5cf6 to
48c4f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #212
Depends on cryostatio/cryostat#725
To test:
cd cryostat-operatorfor ns in apps1 apps2; do oc new-project $ns ; make sample_app ; doneoc new-project testcd cryostat-helmhelm install cryostat --set core.image.repository=quay.io/andrewazores/cryostat --set core.image.tag=k8s-all-namespaces-7 cryostat ./charts/cryostatthis is an image built from feat(k8s): implement wildcard All Namespaces discovery cryostat#725