Skip to content

feat(discovery): implement All Namespaces discovery#213

Merged
andrewazores merged 15 commits intocryostatio:mainfrom
andrewazores:k8s-all-namespaces
Jun 12, 2025
Merged

feat(discovery): implement All Namespaces discovery#213
andrewazores merged 15 commits intocryostatio:mainfrom
andrewazores:k8s-all-namespaces

Conversation

@andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 26, 2024

Fixes #212
Depends on cryostatio/cryostat#725

To test:

  1. cd cryostat-operator
  2. for ns in apps1 apps2; do oc new-project $ns ; make sample_app ; done
  3. oc new-project test
  4. cd cryostat-helm
  5. helm install cryostat --set core.image.repository=quay.io/andrewazores/cryostat --set core.image.tag=k8s-all-namespaces-7 cryostat ./charts/cryostat this is an image built from feat(k8s): implement wildcard All Namespaces discovery cryostat#725
  6. Follow post-installation steps for port forwarding, then open Cryostat UI
  7. Go to Topology and ensure that two sample applications, in apps1 and apps2 namespaces, are discovered

@andrewazores andrewazores added feat New feature or request safe-to-test labels Nov 26, 2024
@andrewazores andrewazores marked this pull request as ready for review November 28, 2024 20:56
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with cryostatio/cryostat-operator#976 (comment) here, this might introduce more elevated access than intended.

@Josh-Matsuoka
Copy link
Contributor

Needs to be rebased, there are a few conflicts to resolve

@andrewazores andrewazores force-pushed the k8s-all-namespaces branch from 26cc9d2 to 53958f7 Compare May 7, 2025 19:05
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think if all-namespace mode is enabled, we can skip generating namespaced role and rolebing manifests, right?

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I guess we will need to adjust rule for clusterrole after cryostatio/cryostat#740 :D

@andrewazores andrewazores merged commit 82465ca into cryostatio:main Jun 12, 2025
7 checks passed
@andrewazores andrewazores deleted the k8s-all-namespaces branch June 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Configure Cryostat for All Namespaces discovery mode

3 participants