feat(annotations): allow user-provided service annotations#249
Merged
andrewazores merged 1 commit intocryostatio:mainfrom May 29, 2025
Merged
feat(annotations): allow user-provided service annotations#249andrewazores merged 1 commit intocryostatio:mainfrom
andrewazores merged 1 commit intocryostatio:mainfrom
Conversation
In some cases, the user require additional annotations on the Services generated by the chart. For example, in AWS, a LoadBalancer Service might require annotations: service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip service.beta.kubernetes.io/aws-load-balancer-scheme: internet-facing service.beta.kubernetes.io/aws-load-balancer-type: external Thus, this change makes it possible without manual user interventions.
andrewazores
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #123. This change focuses on the
Service(especially the one for main deployment).Descriptions
In some cases, the user require additional annotations on the Services generated by the chart. For example, in AWS, a
LoadBalancerService might require annotations:Thus, this change makes it possible without manual user interventions.
Notes
I didn't add any changes under
grafana.servicefield because it is not used anywhere (and should probably be removed).