chore(discovery): replace Endpoints with EndpointSlices#1094
Merged
andrewazores merged 2 commits intocryostatio:mainfrom Jun 12, 2025
Merged
chore(discovery): replace Endpoints with EndpointSlices#1094andrewazores merged 2 commits intocryostatio:mainfrom
andrewazores merged 2 commits intocryostatio:mainfrom
Conversation
Member
Author
|
/build_test |
|
|
2 similar comments
|
|
|
|
|
This PR/issue depends on:
|
Member
Author
|
/build_test |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Depends on cryostatio/cryostat#740
See also cryostatio/cryostat-helm#226
Description of the change:
Adjusts RBAC for Cryostat's usage of EndpointSlices in place of the old Endpoints objects.
How to manually test:
for ns in apps cryostat cryostat-operator; do oc new-project $ns; donemake cert_managerIMAGE_NAMESPACE=quay.io/andrewazores OPERATOR_VERSION=4.1.0-endpointslices-1 DEPLOY_NAMESPACE=cryostat-operator make deploy. This was built withCORE_IMG=quay.io/andrewazores/cryostat:endpointslices-7, which is the corresponding Cryostat PRoc project cryostat ; TARGET_NAMESPACES=apps make create_cryostat_croc project apps ; make sample_app ; oc scale deployment quarkus-test --replicas=3I have also built an operator bundle: https://quay.io/repository/andrewazores/cryostat-operator-bundle?tab=tags
(
4.1.0-endpointslices-1) and confirmed thatmake test-scorecardseems to run and pass as expected with these changes. It will not work in PR CI here until the corresponding Cryostat CR is merged and the upstream snapshot image is published, so that the new implementation is tested alongside the updated RBAC.