Skip to content

feat(diagnostics): ThreadDump deletion notification#1042

Merged
andrewazores merged 4 commits intocryostatio:mainfrom
andrewazores:thread-dump-delete-notification
Sep 11, 2025
Merged

feat(diagnostics): ThreadDump deletion notification#1042
andrewazores merged 4 commits intocryostatio:mainfrom
andrewazores:thread-dump-delete-notification

Conversation

@andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


See #894

Description of the change:

Adds a WebSocket notification emitted when a thread dump is successfully deleted.

Motivation for the change:

Mirrors how other resource deletions (ex. archived recordings, automated rules, stored credentials) are handled - the HTTP API responds with an HTTP 204, and there is also an accompanying WebSocket notification. The WebSocket notification allows all listening clients to update their local state reactively.

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request blocked. webui submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the webui submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.

mergify[bot]
mergify bot previously requested changes Sep 8, 2025
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request blocked. webui submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the webui submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.

@andrewazores andrewazores force-pushed the thread-dump-delete-notification branch from 3db4a81 to d037b3d Compare September 8, 2025 20:26
@andrewazores
Copy link
Member Author

/build_test

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Workflow started at 9/8/2025, 4:32:37 PM. View Actions Run.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

No GraphQL schema changes detected.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

No OpenAPI schema changes detected.

@github-actions
Copy link

github-actions bot commented Sep 8, 2025

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat/actions/runs/17563331686

Josh-Matsuoka
Josh-Matsuoka previously approved these changes Sep 8, 2025
@andrewazores
Copy link
Member Author

@Josh-Matsuoka is the corresponding frontend PR cryostatio/cryostat-web#1802 also good to go?

@Josh-Matsuoka
Copy link
Contributor

@andrewazores Yep, both look good to me.

@andrewazores andrewazores merged commit bca429f into cryostatio:main Sep 11, 2025
8 checks passed
@andrewazores andrewazores deleted the thread-dump-delete-notification branch September 11, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat New feature or request safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants