chore(cleanup): various code quality cleanups #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix resource leak warnings by assigning GenericContainer instances to a local variable before assigning to the field
use direct field assignment (this.container =) instead of intermediate local variable to match the pattern used in S3StorageResource
Member
Author
|
/build_test |
|
Workflow started at 1/14/2026, 10:00:01 AM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
Member
Author
|
/build_test |
|
Workflow started at 1/14/2026, 11:51:18 AM. View Actions Run. |
|
No GraphQL schema changes detected. |
|
No OpenAPI schema changes detected. |
|
CI build and push: All tests pass ✅ |
Member
Author
|
/build_test |
|
Workflow started at 1/14/2026, 2:48:16 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #966
Related to #1061
Description of the change:
expectNotificationwith newer and betterexpectWebSocketNotification