feat(triggers): Add API handler for smart triggers support #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mart triggers to AgentConnection and associated classes
7 tasks
| @RolesAllowed("write") | ||
| @Transactional | ||
| @POST | ||
| public void addSmartTriggers(@RestPath long targetId, @RestForm String definition) { |
Member
There was a problem hiding this comment.
I think some extra OpenAPI annotations would be helpful. The Operation annotation to give a summary/description of these endpoints:
and maybe the Parameter annotation to document what these Strings should look like:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: cryostatio/cryostat-agent#226
Depends on: cryostatio/cryostat-core#625 cryostatio/cryostat-agent#780
Description of the change:
Adds the same 3 api methods as the agent PR (get, post, delete) for controlling smart triggers in agent targets. Adds the necessary support to the AgentConnection, AgentClient, AgentRestClient classes.
TODO: Tests
Opening as Draft for the moment pending any changes needed as the frontend gets developed.
How to manually test: