refactor: Split a base OTX iterator for more use cases#45
Open
xxuejie wants to merge 2 commits intocryptape:mainfrom
Open
refactor: Split a base OTX iterator for more use cases#45xxuejie wants to merge 2 commits intocryptape:mainfrom
xxuejie wants to merge 2 commits intocryptape:mainfrom
Conversation
Collaborator
|
There is ongoing PR: #44. |
Author
|
It remains a question if/when the other big PR is gonna merge. If it gets merged early, I can adjust the code accordingly. |
XuJiandong
requested changes
Apr 23, 2024
| let input_iter = raw_tx | ||
| .inputs() | ||
| .into_iter() | ||
| .skip(otx_structure.input_cell_start) |
Collaborator
There was a problem hiding this comment.
The skip(n) method doesn't report any error when the count of the iterator is smaller than n. The same applies to the take method.
Author
There was a problem hiding this comment.
2 points:
- Note that current code already follows this behavior, I'm just moving code around here, I don't really change anything
- If you think about it: is it really a problem: when one has less input cells than the OTX needs, a different seal will be calculated, making the signature validation failed. So to me, I don't think an error is required here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.