Merged
Conversation
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
oren-z0
reviewed
Dec 3, 2025
| from apps.wallets.wallet import Wallet as _Wallet | ||
| except ModuleNotFoundError as exc: | ||
| if exc.name == "embit": | ||
| if exc.name.startswith("embit"): |
Contributor
There was a problem hiding this comment.
I'm not sure how the naming convention works, but it would be more standard to check:
if exc.name == "embit" or exc.name.startswith("embit."):In case someone releases a package named "embit_something".
Collaborator
|
The PR seems to be just related to test changes, and to me solved the issue, I think this can be merged. CMD: After PR: Before PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #331