-
Notifications
You must be signed in to change notification settings - Fork 93
Add M3Y scanner #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add M3Y scanner #335
Conversation
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the M3Y QR scanner and fixes an issue where the GM65 scanner fails to read large single QR codes. The implementation introduces model detection logic to support both scanner types with their distinct communication protocols.
- Added M3Y scanner support with BCC checksum validation and M3Y-specific command protocol
- Increased UART read buffer from 2048 to 4096 bytes to handle large QR codes
- Implemented enhanced data reading logic with end-of-line validation to ensure complete QR code capture
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Tested the QR Codes with the M3Y Scanner ✅3out_1change.mp4 Tested the QR Codes with the GM65 Scanner: -- |
|
Now testing again with the normal v1.9.0 Firmware: #Tested the QR Codes with the GM65 Scanner: #Tested the QR Codes with the M3YScanner: |
|
We’ll leave this out of scope for this PR since it’s not related to the scanner. The issue is with the QR contents, which uses an unimplemented
So we need to focus on cases where the M3Y scanner turns off while there is still data to read, or when the data is too difficult for it to scan. |
|
EDITED: Added this QR also to the PR description BEFORE THIS PR, this animated QR p1of9 made GM65 and M3Y to STOP readingmulti2-2specter-2025-12-19_12.15.35.mp4 |
|
I believe this PR is ready to be merged. Please test it with both GM65 and M3Y scanners, and compare the behavior with Specter-DIY v1.9.0 to better understand the issues that were addressed. Testing with both the shield and the Waveshare Barcode Scanner board would also be appreciated. |
… async _restart_scanner
|
Tested all the QR Codes in different configurations:
new firmare is this here: |
|
My tests also in table format: |
















close #314
BEFORE THIS PR, both scanners GIVE ERROR when read this
UR:CRYPTO-PSBTQR code below (12w action is the key):To scan, maybe it is better to download the below file, open it, and zoom out to approximately 60% of its size:

BEFORE THIS PR, both scanners STOP reading this animated Specter p1of9 QR (its content is the 12w action mnemonic)
multi2-2specter-2025-12-19_12.15.35.mp4