-
Notifications
You must be signed in to change notification settings - Fork 9
RIP Plausible #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RIP Plausible #126
Conversation
WalkthroughThis pull request involves multiple changes across JavaScript, HTML, and configuration files to adjust the website's analytics tracking setup. The modifications consistently remove references to the Plausible analytics tool. In several JavaScript files, code related to initializing and triggering Plausible tracking—such as event listeners and function calls—has been removed or replaced with direct calls (e.g., using Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
hugo.toml (1)
128-128: Revise Content-Security-Policy – Verify removal of external Paddle source.
The updated Content-Security-Policy header on line 128 is intended to remove the reference tohttps://paddle.s3.amazonaws.com/from theimg-srcdirective. Please confirm that this domain is no longer needed for loading any required assets. If Paddle-hosted images or assets are in use elsewhere, additional adjustments might be necessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (39)
assets/js/404.js(0 hunks)assets/js/base.js(0 hunks)content/downloads/android.de.html(2 hunks)content/downloads/android.en.html(2 hunks)content/downloads/ios.de.html(1 hunks)content/downloads/ios.en.html(1 hunks)content/downloads/linux.de.html(2 hunks)content/downloads/linux.en.html(2 hunks)content/downloads/mac.de.html(1 hunks)content/downloads/mac.en.html(1 hunks)content/downloads/win.de.html(2 hunks)content/downloads/win.en.html(2 hunks)content/sponsors.de.html(1 hunks)content/sponsors.en.html(1 hunks)hugo.toml(1 hunks)layouts/_default/baseof.html(0 hunks)layouts/android/single.html(1 hunks)layouts/donate/list.html(2 hunks)layouts/downloads/list.html(1 hunks)layouts/for-individuals/single.html(4 hunks)layouts/for-teams/single.html(5 hunks)layouts/hub-managed/single.html(6 hunks)layouts/hub-self-hosted/single.html(2 hunks)layouts/index.html(6 hunks)layouts/partials/android-accrescent.html(1 hunks)layouts/partials/android-download.html(1 hunks)layouts/partials/android-fdroid.html(2 hunks)layouts/partials/android-getkey.html(1 hunks)layouts/partials/donate-creditcard.html(2 hunks)layouts/partials/donate-crypto.html(1 hunks)layouts/partials/donate-paypal.html(1 hunks)layouts/partials/footer.html(1 hunks)layouts/partials/nav.html(8 hunks)layouts/partials/supporter-cert-contributor.html(1 hunks)layouts/partials/supporter-cert-funder.html(1 hunks)layouts/partials/supporter-cert-influencer.html(1 hunks)layouts/partials/supporter-cert-other.html(1 hunks)layouts/pricing/single.html(9 hunks)layouts/supporter-cert/list.html(2 hunks)
💤 Files with no reviewable changes (3)
- assets/js/404.js
- assets/js/base.js
- layouts/_default/baseof.html
🔇 Additional comments (79)
layouts/partials/android-accrescent.html (1)
16-16: Remove Plausible tracking class – Clean transition to Umami.
The anchor tag on line 16 no longer includes the obsoleteplausible-event-nameattribute and now relies solely on thedata-umami-eventattribute. This change is consistent with the PR objective to remove Plausible analytics and to streamline event tracking.content/sponsors.de.html (1)
67-67: Clean removal of Plausible tracking attribute.
The anchor tag for the GitHub sponsors call-to-action has had theplausible-event-name=sponsors-github-ctaattribute removed while retaining the necessary attributes (e.g.,data-umami-event). This ensures continued tracking via Umami without legacy Plausible remnants.content/downloads/ios.de.html (1)
22-22: Streamline iOS download link attributes.
The removal of theplausible-event-nameclass from the App Store download link simplifies the markup, and the retention of thedata-umami-event="downloads-ios-appstore"attribute ensures that analytics continue to be captured by the new system.layouts/downloads/list.html (1)
28-29: Eliminate outdated Plausible attribute from download link.
The anchor tag previously included theplausible-event-name=downloads-all-versionsattribute. Its removal, while preserving thedata-umami-eventattribute, aligns with the overall PR goal of deprecating Plausible in favor of Umami for analytics.layouts/android/single.html (1)
36-36: Tracking Attribute Update in Key Recovery Button
The removal of theplausible-event-nameattribute in favor of usingdata-umami-event="android-keyrecovery-form"aligns well with the PR objective to phase out Plausible. The button retains its core functionality and proper event tracking.content/downloads/win.de.html (1)
30-33: Consistent Analytics Tracking for Windows Downloads
The updates in this section remove the now-unnecessaryplausible-event-nameattribute and correctly rely on thedata-umami-eventattribute for tracking. This change is consistent with the overall objective to eliminate Plausible references while preserving analytics capabilities.content/sponsors.en.html (1)
67-70: Sponsor CTA Tracking Attribute Update
The removal of theplausible-event-nameattribute from the "Become a Sponsor via GitHub" call-to-action is correctly handled. Retainingdata-umami-eventensures that tracking remains intact without the legacy Plausible attribute.content/downloads/mac.de.html (1)
30-37: Download Button Tracking Update for macOS (German)
In this update, theplausible-event-nameattribute has been removed from the download links, with tracking maintained viadata-umami-event. This reflects the project’s broader move away from Plausible while ensuring that user actions are still appropriately tracked.content/downloads/mac.en.html (1)
30-37: Download Button Tracking Update for macOS (English)
The removal of theplausible-event-nameattribute from the download links is well executed. By usingdata-umami-eventconsistently for both the Apple Silicon and Intel download buttons, the changes support the PR objective while preserving core functionality and user experience.layouts/partials/android-download.html (2)
16-16: Updated Tracking Attribute for Android Download Button
The removal of the Plausible-specific attribute is correctly reflected by using thedata-umami-event="android-download"attribute. This update complies with the PR objective of removing Plausible tracking while preserving analytic functionality.
19-19: Updated Tracking for SHA256 Signature Toggle
The SHA256 signature toggle link now usesdata-umami-event="android-download-sha256-signature"instead of the Plausible attribute. This consistent update across tracking attributes helps maintain the intended functionality.content/downloads/win.en.html (2)
30-32: Updated Tracking for EXE Installer Download Link
The download link for the EXE installer has been updated to remove the Plausible attribute and now correctly usesdata-umami-event="downloads-win". This change aligns with the overall removal of Plausible tracking.
43-43: Updated Tracking for Portable App Download Link
The portable app download link now featuresdata-umami-event="downloads-win-portable", ensuring that tracking remains consistent across download methods without relying on Plausible.content/downloads/linux.de.html (3)
30-32: Updated Tracking for AppImage (x86_64) Download Link
The anchor tag for the AppImage download now usesdata-umami-event="downloads-linux"after the removal of Plausible-specific attributes. This change ensures consistent event tracking.
33-35: Updated Tracking for AArch64 Download Link
The AArch64 download link correctly implementsdata-umami-event="downloads-linux-aarch64". This update maintains functional consistency and fully removes the Plausible tracking elements.
46-48: Updated Tracking for Linux Package Source Links
The download links for the PPA, AUR, and Flatpak package sources have been updated to use appropriatedata-umami-eventattributes. These changes remove the old Plausible tracking while retaining the intended analytics.layouts/for-teams/single.html (5)
23-23: Updated Tracking for Managed Hub CTA
The managed hub button now usesdata-umami-event="hub-header-managed-cta"instead of the removed Plausible attribute. This update is consistent with the overall tracking changes.
27-27: Updated Tracking for Self-Hosted Hub CTA
The self-hosted hub button has been updated to usedata-umami-event="hub-header-self-hosted-cta". This modification reinforces the uniform removal of Plausible tracking across the site.
147-147: Updated Tracking for Pricing Plans CTA
Transitioning todata-umami-event="hub-pricing"for the pricing button ensures that tracking remains intact while removing any Plausible-specific attributes.
177-179: Updated Tracking for the Contact Us Button
The Contact Us link now utilizesdata-umami-event="hub-contact-us", properly replacing any previous Plausible-based tracking and maintaining consistent analytics.
202-203: Updated Social Media Tracking for Hub Section
Both the Mastodon and LinkedIn links now feature properdata-umami-eventattributes. This update ensures consistency with the new tracking strategy and meets the PR objective.layouts/partials/nav.html (4)
40-46: Consistent Tracking in Desktop Dropdown Items
The dropdown item links now use a dynamicdata-umami-eventattribute based on the page URL (viareplaceRE). This change effectively removes any Plausible-specific tracking while maintaining accurate event attribution.
119-126: Consistent Tracking in Mobile Navigation Links
Mobile navigation links have been updated to usedata-umami-eventwith dynamic values. This consistent approach across navigation elements further aligns with the PR objective of removing Plausible tracking.
146-147: Updated Language Selection Tracking
The language selector links now correctly includedata-umami-eventattributes, ensuring that event tracking remains consistent after the removal of the Plausible-specific attributes.
152-155: Updated GitHub Link Tracking in Mobile Navigation
The GitHub link for mobile navigation now employsdata-umami-event="nav-github", harmonizing with the updated tracking strategy and eliminating any Plausible attributes.layouts/partials/android-getkey.html (1)
23-23: Removal of Deprecated Tracking Attribute
The button on line 23 now relies solely on thedata-umami-eventattribute instead of the removedplausible-event-nameattribute. This change aligns with the PR objective to deprecate Plausible and keep analytics tracking consistent.layouts/pricing/single.html (8)
14-17: Streamline Analytics on Individuals Tab Button
The button for the individuals pricing option now excludes any obsoleteplausible-event-nameattribute and usesdata-umami-event="pricing-individuals-tab". This ensures consistency with the migration to Umami tracking.
50-55: Simplified Tracking for Desktop CTAs
Both anchor tags for desktop call-to-action buttons have had their deprecated tracking attributes removed. Relying solely ondata-umami-event(values"pricing-desktop-cta-1"and"pricing-desktop-cta-2") simplifies the markup and keeps event tracking unified.
98-100: Updated Android Download CTA
The Android download link now exclusively usesdata-umami-event="pricing-android-cta", confirming the removal of Plausible-specific tracking and ensuring tracking integrity across devices.
154-157: Refined iOS CTA for Consistent Analytics
The iOS download button has been updated to remove any legacy tracking attributes. It now solely usesdata-umami-event="pricing-ios-cta", which is consistent with the overall analytic migration.
219-221: Consistent Hub Community CTA Tracking
The CTA for the hub community self-hosted option now only containsdata-umami-event="pricing-hub-community-self-hosted-cta", contributing to a clean, unified analytics setup.
285-287: Unified Tracking on Hub Managed CTA
The button for the managed hub pricing option now exclusively usesdata-umami-event="pricing-hub-standard-managed-cta", ensuring removal of obsolete attributes and consistency across CTAs.
299-301: Refactored Self-Hosted Hub CTA
By replacing any legacy tracking attributes withdata-umami-event="pricing-hub-standard-self-hosted-cta", the self-hosted option button now adheres to the new event tracking strategy.
355-358: Streamlined Hub Enterprise Contact Button
The enterprise contact CTA has been refactored to eliminate the deprecated attribute, relying solely ondata-umami-event="pricing-hub-enterprise-cta". This supports a consistent tracking approach across pricing segments.layouts/partials/android-fdroid.html (3)
16-16: Consistent Analytics for FDroid Repo Button
The "Cryptomator Repository" button now usesdata-umami-event="android-fdroid-cryptomator-repo-tab"exclusively, removing any reference to the old Plausible attribute. This change is key to the overall migration.
19-19: Main Repository Button Update
The update on line 19 removes outdated tracking attributes in favor ofdata-umami-event="android-fdroid-main-repo-tab", ensuring alignment with the new analytics setup.
26-26: Updated QR Code Link Tracking
The QR code link’s tracking is now handled solely viadata-umami-event="android-fdroid-cryptomator-repo-qr-code", which simplifies maintenance and improves consistency.layouts/hub-managed/single.html (5)
72-76: Streamlined Step 1 Button Tracking
The email validation button for Step 1 now usesdata-umami-event="hub-managed-step-1", removing any legacy Plausible attributes. This update supports a consistent event tracking mechanism.
104-107: Unified Team & Subdomain Validation Tracking
For Step 2, the button now exclusively relies ondata-umami-event="hub-managed-step-2", which is in line with the broader removal of Plausible-related code.
129-133: Clear Analytics on Quantity Validation Button
In Step 3, the button triggering quantity validation now usesdata-umami-event="hub-managed-step-3"only—ensuring adherence to the updated tracking strategy.
192-196: Consistent Submit Button Analytics
The submit button in Step 4 has been refactored to drop any old tracking attributes and usedata-umami-event="hub-managed-form", ensuring uniformity in analytics across the form.
227-229: Refined Contact Us CTA for Hub Managed
The contact CTA at the bottom now usesdata-umami-event="hub-managed-contact-us"exclusively. This removal of obsolete tracking attributes helps maintain a clean and consistent analytics implementation.content/downloads/linux.en.html (5)
30-32: Updated x86_x64 Download Link Tracking
The AppImage download link for x86_x64 (line 30) now usesdata-umami-event="downloads-linux", effectively replacing any deprecated Plausible attributes.
33-35: Updated AArch64 Download Link Tracking
The download link for the AArch64 version (line 33) similarly now leveragesdata-umami-event="downloads-linux-aarch64", ensuring a unified approach for analytics across download options.
46-46: Consistent Tracking for PPA Link
The PPA link on line 46 now relies solely ondata-umami-event="downloads-linux-ppa", aligning with the newer, simplified tracking methodology.
47-47: Unified Analytics for AUR Links
The update on line 47 removes any legacy tracking attributes, replacing them withdata-umami-event="downloads-linux-aur"for both AUR links.
48-48: Standardized Tracking for Flatpak Link
The Flatpak download link now exclusively usesdata-umami-event="downloads-linux-flatpak", which maintains consistency with the overall removal of Plausible attributes.layouts/partials/footer.html (1)
7-12: Consistent Removal of Deprecated Tracking Attributes in FooterThe
<a>tags have been updated by removing theplausible-event-nameattribute and relying solely ondata-umami-eventfor analytics tracking. This change is consistent across the links (e.g., Downloads, Merchandise, and Press Kit) and meets the PR objective to eliminate Plausible-specific references without affecting link functionality.layouts/hub-self-hosted/single.html (2)
23-35: Uniform Update of Deployment Input ElementsThe radio input elements for the Kubernetes and Docker Compose (Prod/Test) options now exclusively use
data-umami-eventfor event tracking. The removal of any Plausible-specific attributes from these elements is cleanly executed and ensures consistency with the new analytics setup.
312-312: Updated Contact Button TrackingThe contact button now leverages
data-umami-event(with the value"hub-self-hosted-contact-us") after the removal of the deprecatedplausible-event-nameattribute. This maintains tracking consistency without altering the button’s functionality.content/downloads/ios.en.html (1)
22-22: Clean Removal of Plausible Tracking from iOS Download LinkThe removal of the
plausible-event-nameattribute from the iOS App Store download link in favor ofdata-umami-eventis clear and adheres to the overall analytics update in the PR. Tracking remains intact while the code is simplified.layouts/partials/supporter-cert-other.html (1)
14-14: Streamlined Tracking in Supporter Certificate FormThe submit button for the “other” supporter certificate form now uses
data-umami-event="supporter-cert-other-form"after the removal of the Plausible-specific attribute. This change simplifies the element without affecting its functionality or analytics tracking.layouts/partials/supporter-cert-contributor.html (1)
18-18: Consistent Analytics Update for Contributor FormThe submit button in the contributor certificate form has been updated to remove the
plausible-event-nameattribute, using onlydata-umami-event="supporter-cert-contributor-form"for tracking. This update is consistent with the other files and meets the PR objective to remove Plausible references.layouts/partials/donate-paypal.html (1)
8-8: Removal of Plausible Tracking AttributeThe
plausible-event-nameattribute has been removed from the button. The button now only uses thedata-umami-eventattribute for event tracking, which aligns seamlessly with the PR objective of replacing Plausible analytics.layouts/partials/donate-crypto.html (1)
15-15: Consistent Update for TrackingThe removal of the
plausible-event-nameattribute on the button has been executed cleanly. The button retains thedata-umami-eventattribute to support the new tracking setup, meeting the PR objectives.content/downloads/android.en.html (2)
24-24: Streamlined Google Play LinkThe
<a>element for the Google Play download now relies solely ondata-umami-eventfor tracking. This removal of theplausible-event-nameclass meets the overall goal without any impact on link functionality.
36-36: Streamlined APK LinkSimilarly, the APK download link has been updated to remove the
plausible-event-nameattribute, keeping onlydata-umami-eventfor tracking. This change is consistent with the PR’s intent and preserves the link’s functionality.layouts/partials/supporter-cert-influencer.html (1)
14-14: Simplified Event Tracking on Form ButtonThe button element now excludes the
plausible-event-nameattribute and solely relies on thedata-umami-eventattribute. This simplification aligns with the PR objectives while leaving the form’s functionality intact.layouts/partials/supporter-cert-funder.html (1)
31-31: Accurate Removal for Funders’ Checkout ButtonThe button within the funder form has been updated to remove the
plausible-event-nameattribute. Retaining only thedata-umami-eventattribute meets the PR's objectives to transition from Plausible to another tracking system without affecting functionality.layouts/donate/list.html (2)
23-23: Update: Use of New Analytics Event Attribute on Donation Tabs
The button now uses thedata-umami-eventattribute (donate-{{ substr .Params.TabHash 1 }}-tab) instead of a Plausible-specific attribute. This change is consistent with the PR objective of removing Plausible references.
51-51: Update: Customer Portal Button Analytics Attribute
The customer portal form button now correctly includes thedata-umami-event="donate-customer-portal-form"attribute, replacing the removed Plausible attribute. This ensures tracking continues seamlessly with Umami.layouts/supporter-cert/list.html (2)
23-23: Update: Supporter Certificate Tab Button Tracking
The tab button now usesdata-umami-event="supporter-cert-{{ substr .Params.TabHash 1 }}-tab". Removing the Plausible attribute aligns with the broader analytics update across the project.
54-54: Update: Supporter Certificate Recovery Form Button Tracking
The recovery form button is now tagged withdata-umami-event="supporter-cert-recovery-form", replacing the outdated Plausible attribute. The update is consistent and maintains the intended tracking functionality.layouts/index.html (7)
31-31: Update: "For Individuals" CTA Link Tracking Attribute
The CTA link for the “for-individuals” section has been updated to usedata-umami-event="home-header-individuals-cta". This correctly replaces the removed Plausible attribute.
35-35: Update: "For Teams" CTA Link Tracking Attribute
The “for-teams” button now includesdata-umami-event="home-header-teams-cta", ensuring the removal of Plausible tracking is complete and the event is handled by Umami.
82-84: Update: "Get Started for Individuals" Button Tracking
The “Get Started for Individuals” button now usesdata-umami-event="home-get-started-individuals-cta", replacing any Plausible attributes. This maintains consistent tracking across the site.
120-122: Update: "Get Started for Teams" Button Tracking
The “Get Started for Teams” button is updated to includedata-umami-event="home-get-started-teams-cta", ensuring that the event tracking has been fully migrated.
135-135: Update: Newsletter Form Button Tracking
The newsletter subscription button now carriesdata-umami-event="home-newsletter-form". This change aligns with the overall removal of Plausible references.
148-149: Update: Social Media Link Tracking Attributes
Both the Mastodon and LinkedIn anchor tags have been updated withdata-umami-eventattributes (home-mastodonandhome-linkedin, respectively), ensuring that user interactions are tracked by Umami.
174-174: Update: Sponsor Button Tracking Attribute
The Sponsor button now usesdata-umami-event="home-become-sponsor", replacing the removed Plausible attribute. This completes the tracking update for this CTA.content/downloads/android.de.html (2)
22-24: Update: Google Play Link Tracking for Android Downloads
The Google Play button has been updated withdata-umami-event="downloads-android-googleplay", effectively replacing any Plausible event tracking. This ensures proper analytics collection using Umami.
32-35: Update: APK Download Link Tracking
The APK download link now includesdata-umami-event="downloads-android-apk", removing the obsolete Plausible tracking attribute. The functionality for download remains unchanged.layouts/partials/donate-creditcard.html (2)
46-49: Update: One-Time Credit Card Donation Button Tracking
The one-time donation button now usesdata-umami-event="donate-creditcard-onetime-checkout". This change removes the Plausible-specific attribute, ensuring consistency with the new Umami tracking mechanism.
60-62: Update: Recurring Credit Card Donation Button Tracking
The recurring donation button is now tagged withdata-umami-event="donate-creditcard-recurring-checkout", replacing the previous Plausible attribute. This update meets the analytics tracking migration objectives without affecting functionality.layouts/for-individuals/single.html (5)
21-21: Removedplausible-event-nameattribute from the CTA link.
The anchor element for the downloads CTA now solely usesdata-umami-eventfor analytics tracking, fully aligning with the PR objective of removing Plausible-related code.
172-172: Removedplausible-event-nameattribute from the community button.
This update ensures that the community join button relies only ondata-umami-event, which is consistent with the overall migration away from Plausible.
184-184: Removedplausible-event-nameattribute from the newsletter subscribe button.
The newsletter form button now consistently usesdata-umami-eventfor tracking, supporting the intended removal of Plausible references without affecting functionality.
197-197: Removedplausible-event-nameattribute from the Mastodon social link.
The social media link now solely relies ondata-umami-eventfor tracking, which meets the PR objective.
198-198: Removedplausible-event-nameattribute from the LinkedIn social link.
This change aligns with the overarching removal of Plausible tracking attributes while preserving the intended analytics events withdata-umami-event.
No description provided.