Remove dashes in BIP numbers and change to SegWit version 2

[dplusplus1024]

Updated BIP references to follow the common convention of using a space after “BIP” (e.g., “BIP 173” instead of “BIP-173”).

Also changed SegWit version from 3 to 2. While bc1r was a fun nod to "quantum (r)esistant," jumping versions arbitrarily for stylistic reasons isn’t ideal.

[cryptoquick]

I'm personally not in favor of this change. @EthanHeilman @jbride Thoughts?

[EthanHeilman]

Thanks for this issue and review!

Here is my take on these two issues.

Updated BIP references to follow the common convention of using a space after “BIP” (e.g., “BIP 173” instead of “BIP-173”).

I'm favor of making this change, is there some documentation I can point to in case we get a review that says I should in fact be using hyphens?

BIP 003 does not use hyphens https://github.com/bitcoin/bips/blob/master/bip-0003.md

BIP 443 which is also very recent does use hyphens https://github.com/bitcoin/bips/blob/master/bip-0443.mediawiki

Also changed SegWit version from 3 to 2. While bc1r was a fun nod to "quantum (r)esistant," jumping versions arbitrarily for stylistic reasons isn’t ideal.

If this was done as just a fun nod, I would agree with you. However the intent here is not fun, but user safety. BIP should make that more clear.

The "R for resistant", functions as a mnemonic and makes it earlier for users to remember. Allowing users to, at a glance, determine if an output is Quantum-Resistant or not based it being bc1r... is helpful for avoiding accidents and letting users assess which if any of their addresses are vulnerable to long-exposure attacks. You really don't want to be spending funds to a bc1p... address if bc1p... addresses are vulnerable.

Is there any reason not to assign segwit versions based on the letter rather than the number to help hint to users the output type from the address?

[cryptoquick]

Based on community feedback, we have decided to accept this change. @dplusplus1024 can you please resolve the conflicts in this branch?

[dplusplus1024]

Conflicts resolved. I kept version 2 as originally proposed, but I yielded on the hyphens in byte sizes after seeing the convention in other BIPs. Also fixed a few typos along the way.

[EthanHeilman]

@dplusplus1024 Thanks for this review. You caught a lot.