Conversation
AAAMON
commented
Aug 4, 2025
AAAMON
commented
- Fix: internal and external shares
- Fix: "Open in Cryptpad" not showing
- Fix: german translations.
wginolas
left a comment
wginolas
left a comment
There was a problem hiding this comment.
Can you also fix the eslint warnings that show here: https://github.com/cryptpad/nextcloud-open-in-cryptpad/pull/44/files ?
| * Always add main script | ||
| */ | ||
| Util::addInitScript(self::APP_ID, 'openincryptpad-main', 'files'); | ||
| // Util::addInitScript(self::APP_ID, 'openincryptpad-main', 'files'); |
There was a problem hiding this comment.
The LoadAdditionalScriptsEvent does work in older NC versions (we support) right? Than we can remove boot completely.
There was a problem hiding this comment.
Removing boot gives an internal server error and breaks NC itself. I think we can keep it empty. (and maybe at some point we will need to implement a 'global' script again)
| if (!$this->permissionService->hasWritePermission($id)) { | ||
| return new DataResponse('', Http::STATUS_FORBIDDEN); | ||
| } | ||
| // if (!$this->permissionService->hasWritePermission($id)) { |
There was a problem hiding this comment.
I think this needs to stay. I need to check the rest of the code to say more.
| if (!$this->permissionService->hasWritePermission($id)) { | ||
| return new DataResponse('', Http::STATUS_FORBIDDEN); | ||
| } | ||
| // if (!$this->permissionService->hasWritePermission($id)) { |
There was a problem hiding this comment.
I think this needs to stay. I need to check the rest of the code to say more.
When in view only mode we let CryptPad create a session key and ignore it. This way the user will always be alone in his CryptPad session.
2 participants
