Skip to content

Conversation

Nadrieril
Copy link
Collaborator

@Nadrieril Nadrieril commented Jul 22, 2025

These are the changes I made to the frontend for the purposes of Charon over the last few weeks. In rough order, the changes looks like:

I fixed import_thir.ml but not all the engine tests pass. I'll leave that to you.

The branch consists of a merge of about 10 branches that each could have been a PR; you can review merge-commit-by-merge-commit if you want, the bullet points above would be roughly the PR titles.

Nadrieril added 30 commits July 1, 2025 15:28
This way, the special `ImplExpr::SelfImpl` is only valid within a trait
declaration.
They weren't used anywhere. This also removes `IsState` which was an
union of these traits.
In preparation for being able to insert new clauses after initial
construction.
@W95Psp
Copy link
Member

W95Psp commented Jul 22, 2025

Wow, thank you, that's a lot of work!
I will take some time to do some reviews tomorrow morning, not sure I'll be able to go through everything though ^^'

Copy link
Member

@W95Psp W95Psp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!
I've merged main and fixed a few regressions, but now I'm looking into more regressions on libcrux.
Will post an update whenever this is fixed.

@W95Psp
Copy link
Member

W95Psp commented Jul 28, 2025

I pushed another fix for the treatment of the new Self bounds in the engine.
Now, I expect some hashes to change in libcrux, but we currently have a regression.
So let's wait for that regression to be fixed, then we will merge this PR (after patching libcrux, probably).

Nadrieril and others added 2 commits July 29, 2025 11:16
@Nadrieril
Copy link
Collaborator Author

Nadrieril commented Sep 8, 2025

@W95Psp what's the status of this?

@W95Psp
Copy link
Member

W95Psp commented Sep 9, 2025

Looking at it again now, should be ok!
Sorry for the long waiting time :(

Running:

Those failed because of hashes, now I'm patching them.


I fixed libcrux hashes in frontend-upgrades-hash-fixes, now running the jobs again:

W95Psp added a commit to cryspen/libcrux that referenced this pull request Sep 9, 2025
@W95Psp
Copy link
Member

W95Psp commented Sep 9, 2025

The CI from libcrux is green, let's see what hax' CI says.
(It will fail at ML-KEM, I'm running it for the other tests, will force merge after that)

@W95Psp W95Psp self-requested a review September 9, 2025 12:53
@W95Psp W95Psp added this pull request to the merge queue Sep 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 9, 2025
@W95Psp
Copy link
Member

W95Psp commented Sep 9, 2025

I pushed cryspen/libcrux#1136, let's merge this one.

@W95Psp W95Psp merged commit af86315 into cryspen:main Sep 9, 2025
18 checks passed
@Nadrieril Nadrieril deleted the upstream-pr branch September 9, 2025 14:33
github-merge-queue bot pushed a commit to cryspen/libcrux that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants