-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Hash#transform_keys!
#16280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrykonchin
wants to merge
1
commit into
crystal-lang:master
Choose a base branch
from
andrykonchin:ak/add-hash-transform-keys-bang
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+41
−0
Open
Add Hash#transform_keys!
#16280
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1755,6 +1755,24 @@ class Hash(K, V) | |
| end | ||
| end | ||
|
|
||
| # Destructively transforms all keys using a block. Same as transform_keys but modifies in place. | ||
| # The block cannot change a type of keys. | ||
| # The block yields the key and value. | ||
| # | ||
| # ``` | ||
| # hash = {"a" => 1, "b" => 2, "c" => 3} | ||
| # hash.transform_keys! { |key| key.upcase } | ||
| # hash # => {"A" => 1, "B" => 2, "C" => 3} | ||
| # hash.transform_keys! { |key, value| key * value } | ||
| # hash # => {"a" => 1, "bb" => 2, "ccc" => 3} | ||
| # ``` | ||
| def transform_keys!(&block : K, V -> K) : self | ||
| transformed_hash = self.transform_keys(&block) | ||
| initialize_dup_entries(transformed_hash) # we need only to copy the buffer | ||
| initialize_copy_non_entries_vars(transformed_hash) | ||
| self | ||
| end | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It probably makes sense to move the copying logic into a new method |
||
|
|
||
| # Returns a new hash with the results of running block once for every value. | ||
| # The block can change a type of values. | ||
| # The block yields the value and key. | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: It would be nice to add an example where the transformed key type is a subtype of the original type. This should already work correctly because the proc's output type is
K. But a spec would make sure it stays that way.{"1" => "foo", 2 => "bar"}.transform_keys!(&.to_i).should eq({1 => "foo", 2 => "bar"})