Extract Crystal::EventLoop#shutdown from #close
#16288
Merged
+58
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Oct 28, 2025
This was referenced Oct 28, 2025
straight-shoota
approved these changes
Oct 28, 2025
|
Refactored to now use |
ysbaddaden
force-pushed
the
refactor/add-event-loop-before-close-hook
branch
from
c792df9 to
28bc979
Compare
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Oct 30, 2025
ysbaddaden
changed the title
Crystal::EventLoop#before_close from #closeCrystal::EventLoop#shutdown from #close
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Oct 30, 2025
straight-shoota
approved these changes
Oct 30, 2025
Co-authored-by: Johannes Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the
#before_close(io)#shutdown(io)method out of the#closemethod to distinguish the different aspects of closing:#shutdown(io)does the cleanup after closing the IO object but before closing the actual system (socket) fd or handle.#close(io)closes the system (socket) fd or handle.Required by #16289 (then #16209) to fix #16127.
Similar to #16145 but using a specific callback because event loops might have a different behavior in after reopen than before close.