-
Notifications
You must be signed in to change notification settings - Fork 92
Justify + Nixify #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bohendo
wants to merge
13
commits into
master
Choose a base branch
from
nixify
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Justify + Nixify #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use python 3.9 in some linters consolidate linter CI workflows debug lint ci rm custom bash setup set NIX_PATH setup cachix give cachix a name set nixpkgs channel rm nix path setter log linter versions enable cachix pin nixpkgs in mypy disable non-lint workflows for easier ci debugging install mypy types before linting tweak type installation make mypy noninteractive clean up hack mypy linter
|
bohendo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces 2 new files:
justfileandflake.nixin the project root. These provide a few new commands that are helpful for developers:just build: build an executable which will be available via a symlink at./result/bin/crytic-compilejust install: after building, install the built result (aka add it toPATH) so that it's available by just typingcrytic-compilejust dev: pre-packaged, hermetically sealed dev environment, no virtualenvwrapper needed. This command will open a new shell that exposes a temporary and hot-reloadablecrytic-compile, this executable will update when the source code changes for a quick and easy tweak/check cycle. (TODO: this works nicely withnix-shell shell.nixbut is not hot-reloadable via flake.nix, I should fix this)just lint: runsblack,darglint,mypy, andpylintcode formatters/lintersjust black: runs only theblackcode formatter (ditto for the other lint commands)just test: runs all available tests (onlyhardhatandmonorepotests for now, more coming soon)just test-hardhat: runs only the hardhat tests locally (also works withmonorepo)Keep in mind:
nixandjustto be installed. Ifnixis already installed, you can installjustwithnix-env -iA nixpkgs.justor add it to yourconfiguration.nixfile if you're using NixOS/nix-darwin.just lintshould take on the order of 20 seconds and negligible bandwidth. Luckily, if some other project requires the same dependencies, they'll be cached & won't need to be downloaded again. The dependencies required to run thebuild,dev, andlintcommands overlap but are not identical so each one will take a while to run the first time.justand/ornix, ignore these few new files & continue developing as you always have, nothing else should be impacted.