Skip to content

Detect when a property/optimization is invalid#1536

Merged
gustavo-grieco merged 6 commits intomasterfrom
fix-invalid-property
Mar 18, 2026
Merged

Detect when a property/optimization is invalid#1536
gustavo-grieco merged 6 commits intomasterfrom
fix-invalid-property

Conversation

@gustavo-grieco
Copy link
Collaborator

Fix for #614

@elopez elopez added the ci-all-solc Test a PR with all solc versions label Mar 13, 2026
| NoFuncs
| NoTests
| OnlyTests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

NoFuncs -> "ABI is empty, are you sure your constructor is right?"
NoTests -> "No tests found in ABI. If you are using assert(), use --test-mode assertion"
OnlyTests -> "Only tests and no public functions found in ABI"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change


isOptimizationMode :: TestMode -> Bool
isOptimizationMode "optimization" = True
isOptimizationMode _ = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isOptimizationMode _ = False
isOptimizationMode _ = False

Copy link
Member

@elopez elopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gustavo-grieco gustavo-grieco merged commit 6e589d4 into master Mar 18, 2026
25 checks passed
@gustavo-grieco gustavo-grieco deleted the fix-invalid-property branch March 18, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-all-solc Test a PR with all solc versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants