Skip to content

Conversation

@0xalpharush
Copy link
Contributor

No description provided.

@anishnaik anishnaik marked this pull request as ready for review January 14, 2025 23:50
Copy link
Member

@dguido dguido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - This is a correct and valuable fix.

Assessment:

  • ✅ Legitimate performance improvement using RWMutex for read-heavy event publishing
  • ✅ Maintains synchronization guarantees - no new race conditions
  • ✅ Removes serialization bottleneck in parallel worker event publishing
  • ✅ Matches existing RWMutex pattern used elsewhere in codebase (e.g., non_persistent_cache.go)

This allows all workers to publish events concurrently rather than waiting in line.

@dguido dguido merged commit c90ecd3 into master Jan 20, 2026
17 of 18 checks passed
@dguido dguido deleted the fix/use-rwmutex branch January 20, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants