WIP: Migrate from argparse to Typer

[DarkaMaul]

Description

This PR replaces #2220

1. Replace argparse with typer

Modify Slither CLI from argparse to Typer.

With this migration we gain :

• Argument validation using Python type hints
• A nicely formatted help message
• Auto completion support ( type slither c<TAB>)

I kept the crytic-compile module as if, and created a backward compatibility layer with it.

Notable points :

• Arguments are either associated to the main command (slither) or with one of its subcommand (detect). For instance, the formatting or the output file.
• A backward compatibility layer to keep the slither . has been added, converting it to the new format : slither detect ..
• A new SlitherState object is accessible. It contains every parsed argument on the upper command to be accessed by the sub commands if needed. For instance, this is where are stored the crytic-compile arguments.

2. Update tools to use sub-commands

Each slither tool now has its own subcommand.
Use like slither mutate <>

Screenshots

Remaining TODO

• make sure flags are under the right subcommand
• determine if we want to gate dependencies e.g. pip install slither[read-storage] to use slither read-storage
• EXTENSIVE TESTING
  While I tried to test the changes I made, it is touching almost every part of the code. Moreover, it contains breaking changes. So we should try to test a bit more (and on more than a single computer) before merging.
• review where each flags is used and if not, simplify the CLI

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[0xalpharush]

• add something like --long-help from Feat/subcommands #2220 to show the crytic-compile flags that can be used
• --no-fail only applies to the echidna printer and does not need to be apart of the top level command line options
• --wiki-detectors should remain suppressed as it is not user facing
• It looks like slither mutate is missing from the list? We can probably not show demo and delete check-kpsec
• add description to format
• for slither-read-storage, we can isolate the dependencies as outlined in break functionality up into subcommands #1928
• make thinks like --detect and --print suggest available options

[0xalpharush]

It'd be great to put together better testing infra for our CLI so we can feel confident about this and also changes like #2428 (and quickly iterate on them in the future)

[dguido]

Code Review for PR #2452 (Typer Migration)

Bugs Found

1. Interface detection regression - slither/tools/mutator/__main__.py:286

   if target_contract.name.startswith("I"):

   CLAUDE.md explicitly states: "Use contract.is_interface not contract.name.startswith("I")". This heuristic incorrectly identifies contracts like ImmutableToken as interfaces.

2. kspec_coverage passes wrong type - slither/tools/kspec_coverage/__main__.py:40-41

   kspec_coverage(
       target,  # Target object, not string

   The kspec_coverage() function expects a string path, but receives a Target object. Should be target.target.

3. choose_detectors mutates global DETECTORS list - slither/__main__.py:246,251

   detectors_to_run = all_detector_classes  # Reference to DETECTORS
   ...
   detectors_to_run.remove(local_detectors[detector])  # Mutates global!

   When --exclude is used, this removes detectors from the global DETECTORS list, breaking subsequent runs in the same process. Should use list(all_detector_classes) to create a copy.

4. fastText import uses wrong case - slither/tools/similarity/model.py:3-4

   from fastText import load_model
   from fastText import train_unsupervised

   The package name is fasttext (lowercase), not fastText. This will cause ModuleNotFoundError on case-sensitive systems.

5. similarity tool input key mismatch - slither/tools/similarity/__main__.py:67 vs plot.py:38, test.py:19, train.py:17

   # __main__.py stores as:
   "input_": input_,
   
   # But consumers expect:
   kwargs.get("input")  # Without underscore

   The key stored is input_ but all consumers look for input. The similarity tool will always fail with "requires input parameter" errors.

6. CI scripts use old command format - scripts/ci_test_interface.sh, scripts/ci_test_upgradability.sh:186,199
   Scripts still use standalone commands like slither-interface and slither-check-upgradeability instead of the new subcommand format (slither interface, slither check-upgradeability). Tests 14 and 15 in upgradability appear to still use the old format.

CLAUDE.md Violations

7. Function length violation - slither/__main__.py:413-784
   The detect() function is ~371 lines. CLAUDE.md requires "≤80 lines/function". Consider extracting the parameter definitions, detector execution logic, and output handling into separate functions.

8. Commented-out code - slither/tools/mutator/__main__.py:174

   # test_command: str = args.test_cmd

   CLAUDE.md states: "No commented-out code (delete it)".

---

🤖 Generated with Claude Code