Better assembly highlighting #507
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdbgui/src/js/SourceCode.tsx
: Added logic for detecting assembly mnemonics and operands (like registers, memory addresses and constats)gdbgui/static/css/gdbgui.css
: Added necessary css-style classes for highlighting the detected assemblySummary of changes
Gdbgui
now highlights all parts of an assembly instruction, instead of interpreting it as one big instruction.Test plan
Tested by running the following commands inside the cloned repo after the changes: