-
Notifications
You must be signed in to change notification settings - Fork 17
Feat: add support for ssh #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mickenordin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, very good.
MahdiBaghbani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition!
I wonder if the wrong response payload (code 200?) should result in red status in the OCM Stub tests
394a320
394a320 to
a841042
Compare
Well, it should indeed! Maybe "orange" if you have such a concept |
|
I've rebased this and made it clear that for ssh access we need a full address in the form |
mickenordin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, good, I started to implement this in amity and figured out I had to have a complete virtual file system if all I had was the public key to distinguish between shares, since that may well be reused between multiple shares across multiple users. Now, that turned out pretty good, so I may keep it, but at least now we don't need to do it that way :)
This PR is stacked on top of #307 and defines support for an
sshprotocol, either for remote access (e.g. viasshfs) or as a data transfer protocol viascp. Fixes #277.In the process of writing it, I realized that the Draft did not include any explanation of the Response payload of a share (!), so that's included as well with a separate commit, which I'd like not to squash when the PR gets merged.
An important issue when dealing with ssh/scp is that a local account for a remote user at the sharing server end has to be used, at variance with web-based protocols where remote users do not require it. @sunetfreitag how is FileSender going to approach this?