Skip to content

Conversation

@glpatcern
Copy link
Member

This PR is stacked on top of #307 and defines support for an ssh protocol, either for remote access (e.g. via sshfs) or as a data transfer protocol via scp. Fixes #277.

In the process of writing it, I realized that the Draft did not include any explanation of the Response payload of a share (!), so that's included as well with a separate commit, which I'd like not to squash when the PR gets merged.

An important issue when dealing with ssh/scp is that a local account for a remote user at the sharing server end has to be used, at variance with web-based protocols where remote users do not require it. @sunetfreitag how is FileSender going to approach this?

mickenordin
mickenordin previously approved these changes Dec 8, 2025
Copy link
Member

@mickenordin mickenordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very good.

MahdiBaghbani
MahdiBaghbani previously approved these changes Dec 8, 2025
Copy link
Member

@MahdiBaghbani MahdiBaghbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition!
I wonder if the wrong response payload (code 200?) should result in red status in the OCM Stub tests

@glpatcern glpatcern dismissed stale reviews from MahdiBaghbani and mickenordin via 394a320 December 8, 2025 10:21
@glpatcern glpatcern force-pushed the feat-ssh branch 2 times, most recently from 394a320 to a841042 Compare December 8, 2025 10:48
@glpatcern
Copy link
Member Author

This is a good addition! I wonder if the wrong response payload (code 200?) should result in red status in the OCM Stub tests

Well, it should indeed! Maybe "orange" if you have such a concept

@glpatcern
Copy link
Member Author

I've rebased this and made it clear that for ssh access we need a full address in the form [email protected]:port/resource/path. Whether the username is receiver-specific or totally generic (similar to [email protected]) is left to the implementation.

Copy link
Member

@mickenordin mickenordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good, I started to implement this in amity and figured out I had to have a complete virtual file system if all I had was the public key to distinguish between shares, since that may well be reused between multiple shares across multiple users. Now, that turned out pretty good, so I may keep it, but at least now we don't need to do it that way :)

@glpatcern glpatcern merged commit cc8c8c1 into develop Dec 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: Support for ssh and scp/sftp

4 participants