Make recipientPublicKey plural #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I order for server-to-server interactions to work over ssh, the recipient OCM server needs to have a private key, that can be used for access, and an implementation may ask the user to upload a key pair for this purpose, or generate one on behalf of the user. However a user may also want to access the share directly using other means, or an enterprise may want to enable third-party-copy and for this reason it will be useful to be able to reply with multiple public keys, used for different purposes.
glpatcern
approved these changes
Dec 12, 2025
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
I see the scope of this, ideally we want some informed opinions on how this is being modeled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I order for server-to-server interactions to work over ssh, the recipient OCM server needs to have a private key, that can be used for access, and an implementation may ask the user to upload a key pair for this purpose, or generate one on behalf of the user.
However a user may also want to access the share directly using other means, or an enterprise may want to enable third-party-copy and for this reason it will be useful to be able to reply with multiple public keys, used for different purposes.