Skip to content

make chunking_parallel_upload_disabled configurable #5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glpatcern merged 1 commit into from
Jan 7, 2026
Merged

make chunking_parallel_upload_disabled configurable #5433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/chunk-parallel-upload.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Enhancement: make chunking_parallel_upload_disabled configurable

https://github.com/cs3org/reva/pull/5433
2 changes: 1 addition & 1 deletion internal/http/services/owncloud/ocs/data/capabilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ type CapabilitiesDav struct {
Chunking string `json:"chunking" xml:"chunking"`
Trashbin string `json:"trashbin" xml:"trashbin"`
Reports []string `json:"reports" mapstructure:"reports" xml:"reports>element"`
ChunkingParallelUploadDisabled bool `json:"chunkingParallelUploadDisabled" xml:"chunkingParallelUploadDisabled"`
ChunkingParallelUploadDisabled bool `json:"chunkingParallelUploadDisabled" mapstructure:"chunking_parallel_upload_disabled" xml:"chunkingParallelUploadDisabled"`
}

// CapabilitiesFilesSharing TODO document.
Expand Down
3 changes: 0 additions & 3 deletions internal/http/services/owncloud/ocs/handlers/cloud/capabilities/capabilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,6 @@ func (h *Handler) Init(c *config.Config) {
Product: "reva",
}
}

// upload protocol-specific details
setCapabilitiesForChunkProtocol(chunkProtocol(h.defaultUploadProtocol), h.c.Capabilities)
}

// GetCapabilities renders the capabilities.
Expand Down
1 change: 0 additions & 1 deletion internal/http/services/owncloud/ocs/handlers/cloud/capabilities/uploads.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ func setCapabilitiesForChunkProtocol(cp chunkProtocol, c *data.Capabilities) {
// 2.7+ will use Chunking V1 if "capabilities > files > bigfilechunking" is "true" AND "capabilities > dav > chunking" is not there
c.Files.BigFileChunking = true
c.Dav.Chunking = ""
c.Dav.ChunkingParallelUploadDisabled = false
c.Files.TusSupport = nil
/*
switch cp {
Expand Down