Skip to content

Make file extensions configurable #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
th-we wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make file extensions configurable #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/markclip.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ SAVE_TYPE_FILE = 'file'
SAVE_TYPE_FILE_IN_FOLDER = 'file in folder'
SAVE_TYPE_DEFAULT_FOLDER = 'default folder'
SAVE_TYPE_CUSTOM_FILE = 'custom file'
FILE_EXT = ['.md', '.markdown', '.mdown', '.mkd', '.mkdown']
SPACE_REPLACER = '-';
SPACE_REG = /\s+/g;

Expand All @@ -33,6 +32,12 @@ module.exports = Markclip =
description: "A folder to save image, use with `saveType = #{SAVE_TYPE_DEFAULT_FOLDER}`"
default: 'img'
order: 30
fileExt:
type: 'array'
description: 'File extensions of markdown files'
default: ['.md', '.markdown', '.mdown', '.mkd', '.mkdown']
order: 40


handleInsertEvent: (e) ->
textEditor = atom.workspace.getActiveTextEditor()
Expand All @@ -46,17 +51,19 @@ module.exports = Markclip =
e.abortKeyBinding()
return

fileExt = atom.config.get('markclip.fileExt')

# CHECK: do nothing with unsaved file
filePath = textEditor.getPath()
if not filePath
atom.notifications.addWarning(PKG.name + ': Markdown file NOT saved', {
detail: 'save your file as ' + FILE_EXT.map((n) => '"' + n + '"').join(', ')
detail: 'save your file as ' + fileExt.map((n) => '"' + n + '"').join(', ')
})
return

# CHECK: file type should in FILE_EXT
# CHECK: file type should in fileExt
filePathObj = path.parse(filePath)
return if FILE_EXT.indexOf(filePathObj.ext) < 0
return if fileExt.indexOf(filePathObj.ext) < 0

saveType = atom.config.get('markclip.saveType')
# atom 1.12 img.toDataURL / atom 1.11 img.toDataUrl
Expand Down