upgrade to golangci-lint v2 #391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
commented
Jul 28, 2025
miparnisari
commented
- Use golang linter v2
- Move to the module plugin system as recommended by https://golangci-lint.run/plugins/module-plugins
- Fix existing linting issues
|
Oh, I did not know about https://golangci-lint.run/plugins/module-plugins/ 👀 |
miparnisari
commented
Jul 30, 2025
Comment on lines
-6
to
-13
| - goworkflows | ||
|
|
||
| linters-settings: | ||
| custom: | ||
| goworkflows: | ||
| path: ./plugin.so | ||
| description: go-workflows | ||
| original-url: github.com/cschleiden/go-workflows/analyzer |
There was a problem hiding this comment.
Not sure why you would use your own linter in your own project 😅
There was a problem hiding this comment.
The repo does contain workflows, like all the different samples and I want to run the linter on those.
There was a problem hiding this comment.
Oh, ok. I can bring it back. Or maybe we can write a unit test that runs the analyzer programmatically?
There was a problem hiding this comment.
Are there any blockers to running this like it used to with the modules approach? I liked that because it made it easy to dogfood when working on samples and to see how it felt
miparnisari
changed the title
cschleiden
force-pushed
the
golang-lint-v2
branch
from
e3e3227 to
0150252
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.