Fix duplicate workflow instance and execution ID fields in logs#406
Merged
cschleiden merged 3 commits intomainfrom Aug 14, 2025
Merged
Fix duplicate workflow instance and execution ID fields in logs#406cschleiden merged 3 commits intomainfrom
cschleiden merged 3 commits intomainfrom
Conversation
Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Workflow instance logger includes duplicate fields
Fix duplicate workflow instance and execution ID fields in logs
Aug 14, 2025
cschleiden
requested changes
Aug 14, 2025
… cleanup test file Co-authored-by: cschleiden <2201819+cschleiden@users.noreply.github.com>
cschleiden
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
workflow.instance.idandworkflow.execution.idfields were appearing multiple times in workflow logs, causing unnecessary duplication and potential confusion in log analysis.Problem
The logger passed into the
Executorwas already enhanced withInstanceIDKeyandExecutionIDKeyfields, but then these same fields were being added again in three other places:NewExecutorfunction (lines 113-116)InstanceIDKeyagain inexecuteEvent()andClose()methodsThis resulted in log entries like:
{ "msg": "Executing event", "workflows.instance.id": "123", "workflows.execution.id": "456", "workflows.instance.id": "123", "workflows.execution.id": "456" }Solution
Removed all redundant field additions while keeping the primary logger enhancement that happens before the executor is created. The changes are minimal and surgical:
.With()call in executor constructor (NewExecutor).With()call inNewWorkflowState()InstanceIDKeyfrom debug logging inexecuteEvent()InstanceIDKeyfrom debug logging inClose()Verification
{ "msg": "Executing event", "workflows.instance.id": "123", "workflows.execution.id": "456" }Fixes #405.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.