178 shocsimpletopology can raise an error on variables without a standard name #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
david-sh-csiro
commented
Jul 10, 2025
david-sh-csiro
commented
- Added more error resistant way of accessing the standard_name attribute for a variable.
- Added basic unit test to check for the error case. (currently the order of the variables in the test dataset is sufficient to raise the error without the fix)
…kup when standard names are missing for variable attributes.
…se and error when there is a missing variable standard name.
mx-moth
approved these changes
Jul 10, 2025
Contributor
mx-moth
left a comment
mx-moth
left a comment
There was a problem hiding this comment.
Looks good!
The test failures are only on the latest dependencies test suite, and are to do with a warning that is no longer raised. It can be ignored, that error can be fixed in a different pull request.
mx-moth
deleted the
178-shocsimpletopology-can-raise-an-error-on-variables-without-a-standard_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.