Use PEP 695 generics #204
Merged
Use PEP 695 generics #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they documented actual values in the code, but now that the generic parameters are more ephemeral, there was nothing to document.
david-sh-csiro
approved these changes
Nov 23, 2025
Collaborator
david-sh-csiro
left a comment
david-sh-csiro
left a comment
There was a problem hiding this comment.
Looks good! Much cleaner now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've dropped Python 3.11 support we can use PEP 695 generics. These are much nicer to use than TypeVar everywhere!
See also #109