Use matplotlib default colourmap #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fall back to matplotlibs configured default, which is usually 'viridis' but can be customised by users. "jet" is a poor choice for many reasons.
It reverted the styling to "classic", probably to prevent massive churn in projects using pytest-mpl when matplotlib changed its defaults. However, the default cmap in "classic" mode is "jet" - the colormap we are trying to avoid!
mx-moth
force-pushed
the
use-default-cmap
branch
from
b431d32 to
cc65451
Compare
mx-moth
force-pushed
the
use-default-cmap
branch
from
cc65451 to
e44f534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default colourmap for plotting functions in emsarray was set to "jet" for historical reasons. These reasons are no longer relevant.
The matplotlib default of "viridis" is an improvement over "jet" in a number of ways. Users can customise the default colourmap used by matplotlib using rcParams. The way emsarray was overriding this means the users defaults would be ignored if customised.
The example plots in the documentation have been updated to reflect this change.