Skip to content

Adds better code example #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2025
Merged

Adds better code example #251

merged 3 commits into from
Aug 14, 2025

Conversation

moebrowne
Copy link
Contributor

The existing code is unnecessarily hard to understand.

arkhi
arkhi reviewed May 24, 2025
View reviewed changes
Copy link
Member

@arkhi arkhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I left two comments. Let me know what you think and do what you feel is better.

moebrowne and others added 2 commits May 26, 2025 16:53
@moebrowne @arkhi
Simplifies condition
32f84e5 
Co-authored-by: Fabien Basmaison <[email protected]>
@moebrowne @arkhi
Updates end date
3b8c934 
Co-authored-by: Fabien Basmaison <[email protected]>
@moebrowne
Copy link
Contributor Author

@arkhi LGTM 😃

@arkhi arkhi merged commit 1c0e78e into css-naked-day:master Aug 14, 2025
@arkhi
Copy link
Member

arkhi commented Aug 14, 2025

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkhi arkhi arkhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moebrowne @arkhi