Improve DX by creating development environment with minimal and documented setup#69
Improve DX by creating development environment with minimal and documented setup#69
Conversation
This is done by making most properties optional and just displaying nothing if no data is available.
daancs
left a comment
There was a problem hiding this comment.
This line (and likely more in this file) throws typeErrors when trying to view timeline on admin page.
|
All in all, the PR lgtm and is a welcome change for future developers to be able to maintain this repo. I couldn't find any other breaking changes. Although, I was wondering why the |
This is to stop timeline events with no category from being created.
It is to stop errors when the image doesn't exist. When an image doesn't exist the 404 page is returned. However Next.js tries to optimize the page, which obviously fails because it's HTML and not an image. I've edited the comment to explain this. Although, I'm still a beginner at Next.js so I could be misunderstanding things. |
|
Might've been a bit too quick on the merge. I'm not sure unoptimized is the best tbh. I guess it could be a fix for if the volume of the images ever gets deleted somehow but if that would happen then we would have other issues. Did you have issues with it when you were developing? |
You're right about that. There is probably a better solution, but that's what I came up with for now. I'll create an issue to address it with a better solution in the future.
I did, since there were no images it would always fail and give errors. Adding |
This pull request aims to provide a better developer experience when getting started working on the website. It does this by providing a development environment powered by Docker Compose and documenting how to get started step-by-step.
Changelog
Below is a list of the changes in this pull request. The format is based on Keep a Changelog.
Added
dev/docker-compose.ymlwhich runs a single-node MongoDB replica set./api/admin/category/update).Changed
ImageWithFallbackto treat empty fallback URLs as having no fallback URL.ImageWithFallbackto useunoptimizedto stop errors when trying to optimize the 404 page, which is HTML and not an image.temp.jstodata.jsto better reflect its purpose.Removed
Fixed
CommitteeManagementDisplayalways showing that the save to database was succeessful even if it failed.