Skip to content

Update gemspec to allow activerecord 8.x #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update gemspec to allow activerecord 8.x #1033

wants to merge 1 commit into from
+1 −1

Conversation

@andynu
Copy link

@andynu andynu commented Nov 8, 2024

Fixes 1032

@davidrunger davidrunger mentioned this pull request Nov 8, 2024
Open
@kmcphillips
Copy link

This is great. +1 to unblocking our rails 8 upgrades.

@aitor
Copy link

aitor commented Nov 8, 2024

+1 Just came from getting the same problem (fixed now) with audited gem (collectiveidea/audited#738). It will be great is some maintainer can merge this.

@aitor aitor mentioned this pull request Nov 8, 2024
Open
@tnir
Copy link

tnir commented Nov 10, 2024

#1031 would be better.

@justinallenmarsh
Copy link

+1

1 similar comment
@justinallenmarsh
Copy link

+1

@arslanaly47
Copy link

+1. Any idea when it will be merged?

@marivaldo
Copy link

+1

1 similar comment
@vsppedro
Copy link

+1

@brupla6126
Copy link

@alexch @ctran Hey guys, it's been 2 years without release and ~50 opened PR. This gem is really useful and worth continue its maintenance. Did you guys think about adding more maintainers or transfering ownership ?

Paul-Bob
Paul-Bob approved these changes Jan 31, 2025
View reviewed changes
Copy link

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iwazzer added a commit to hacomono-lib/annotate_models that referenced this pull request Jun 26, 2025
@iwazzer
Update gemspec to allow activerecord 8.x
e765e79 
ctran#1033
@iwazzer iwazzer mentioned this pull request Jun 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

7 more reviewers

@bartostefan bartostefan bartostefan approved these changes

@arslanaly47 arslanaly47 arslanaly47 approved these changes

@boserh boserh boserh approved these changes

@justinallenmarsh justinallenmarsh justinallenmarsh approved these changes

@p-manoel p-manoel p-manoel approved these changes

@Paul-Bob Paul-Bob Paul-Bob approved these changes

@simplexbruno simplexbruno simplexbruno approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.