Skip to content

Commit 725f593

Browse files
krzkandersson
authored andcommitted
arm64: dts: qcom: msm8996-xiaomi: fix missing clock populate
Commit 338958e ("arm64: dts: qcom: msm8996-xiaomi: drop simple-bus from clocks") removed "simple-bus" compatible from "clocks" node, but one of the clocks - divclk1 - is a gpio-gate-clock, which does not have CLK_OF_DECLARE. This means it will not be instantiated if placed in some subnode. Move the clocks to the root node, so regular devices will be populated. Reported-by: Dmitry Baryshkov <[email protected]> Closes: https://lore.kernel.org/all/CAA8EJprF==p87oN+RiwAiNeURF1JcHGfL2Ez5zxqYPRRbN-hhg@mail.gmail.com/ Cc: [email protected] Fixes: 338958e ("arm64: dts: qcom: msm8996-xiaomi: drop simple-bus from clocks") Signed-off-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Dmitry Baryshkov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 2ca3e84 commit 725f593

File tree

2 files changed

+23
-27
lines changed

2 files changed

+23
-27
lines changed

arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,26 +11,24 @@
1111
#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
1212

1313
/ {
14-
clocks {
15-
divclk1_cdc: divclk1 {
16-
compatible = "gpio-gate-clock";
17-
clocks = <&rpmcc RPM_SMD_DIV_CLK1>;
18-
#clock-cells = <0>;
19-
enable-gpios = <&pm8994_gpios 15 GPIO_ACTIVE_HIGH>;
14+
divclk1_cdc: divclk1 {
15+
compatible = "gpio-gate-clock";
16+
clocks = <&rpmcc RPM_SMD_DIV_CLK1>;
17+
#clock-cells = <0>;
18+
enable-gpios = <&pm8994_gpios 15 GPIO_ACTIVE_HIGH>;
2019

21-
pinctrl-names = "default";
22-
pinctrl-0 = <&divclk1_default>;
23-
};
20+
pinctrl-names = "default";
21+
pinctrl-0 = <&divclk1_default>;
22+
};
2423

25-
divclk4: divclk4 {
26-
compatible = "fixed-clock";
27-
#clock-cells = <0>;
28-
clock-frequency = <32768>;
29-
clock-output-names = "divclk4";
24+
divclk4: divclk4 {
25+
compatible = "fixed-clock";
26+
#clock-cells = <0>;
27+
clock-frequency = <32768>;
28+
clock-output-names = "divclk4";
3029

31-
pinctrl-names = "default";
32-
pinctrl-0 = <&divclk4_pin_a>;
33-
};
30+
pinctrl-names = "default";
31+
pinctrl-0 = <&divclk4_pin_a>;
3432
};
3533

3634
gpio-keys {

arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,14 @@
2020
qcom,pmic-id = <0x20009 0x2000a 0x00 0x00>;
2121
qcom,board-id = <31 0>;
2222

23-
clocks {
24-
divclk2_haptics: divclk2 {
25-
compatible = "fixed-clock";
26-
#clock-cells = <0>;
27-
clock-frequency = <32768>;
28-
clock-output-names = "divclk2";
29-
30-
pinctrl-names = "default";
31-
pinctrl-0 = <&divclk2_pin_a>;
32-
};
23+
divclk2_haptics: divclk2 {
24+
compatible = "fixed-clock";
25+
#clock-cells = <0>;
26+
clock-frequency = <32768>;
27+
clock-output-names = "divclk2";
28+
29+
pinctrl-names = "default";
30+
pinctrl-0 = <&divclk2_pin_a>;
3331
};
3432
};
3533

0 commit comments

Comments
 (0)