Skip to content

Commit e662c90

Browse files
plbossarttiwai
authored andcommitted
ALSA/hda: intel-dsp-config: reduce log verbosity
The information on PCI class/subclass was interesting in the Skylake timeframe, since the DSP was only enabled on a limited number of platforms. Now most Intel platforms do enable the DSP, so the information is less interesting to log. When a DSP driver is used, the common helper may be called multiple times due to deferred probes, but there's no reason to print the same information multiple times. Using dev_info_once() covers all the existing usages for internal cards with DSPs. External cards don't rely on DSPs so far. Signed-off-by: Pierre-Louis Bossart <[email protected]> Reviewed-by: Bard Liao <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent a200df7 commit e662c90

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sound/hda/intel-dsp-config.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci)
668668
return SND_INTEL_DSP_DRIVER_LEGACY;
669669
}
670670

671-
dev_info(&pci->dev, "DSP detected with PCI class/subclass/prog-if info 0x%06x\n", pci->class);
671+
dev_dbg(&pci->dev, "DSP detected with PCI class/subclass/prog-if info 0x%06x\n", pci->class);
672672

673673
/* find the configuration for the specific device */
674674
cfg = snd_intel_dsp_find_config(pci, config_table, ARRAY_SIZE(config_table));
@@ -678,12 +678,12 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci)
678678
if (cfg->flags & FLAG_SOF) {
679679
if (cfg->flags & FLAG_SOF_ONLY_IF_SOUNDWIRE &&
680680
snd_intel_dsp_check_soundwire(pci) > 0) {
681-
dev_info(&pci->dev, "SoundWire enabled on CannonLake+ platform, using SOF driver\n");
681+
dev_info_once(&pci->dev, "SoundWire enabled on CannonLake+ platform, using SOF driver\n");
682682
return SND_INTEL_DSP_DRIVER_SOF;
683683
}
684684
if (cfg->flags & FLAG_SOF_ONLY_IF_DMIC &&
685685
snd_intel_dsp_check_dmic(pci)) {
686-
dev_info(&pci->dev, "Digital mics found on Skylake+ platform, using SOF driver\n");
686+
dev_info_once(&pci->dev, "Digital mics found on Skylake+ platform, using SOF driver\n");
687687
return SND_INTEL_DSP_DRIVER_SOF;
688688
}
689689
if (!(cfg->flags & FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE))
@@ -694,7 +694,7 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci)
694694
if (cfg->flags & FLAG_SST) {
695695
if (cfg->flags & FLAG_SST_ONLY_IF_DMIC) {
696696
if (snd_intel_dsp_check_dmic(pci)) {
697-
dev_info(&pci->dev, "Digital mics found on Skylake+ platform, using SST driver\n");
697+
dev_info_once(&pci->dev, "Digital mics found on Skylake+ platform, using SST driver\n");
698698
return SND_INTEL_DSP_DRIVER_SST;
699699
}
700700
} else {

0 commit comments

Comments
 (0)