Skip to content

Conversation

PlaidCat
Copy link
Collaborator

Rebuild_History BUILDABLE
Rebuilding Kernel from rpm changelog with Fuzz Limit: 87.50% Number of commits in upstream range v5.14~1..master: 280717 Number of commits in rpm: 3
Number of commits matched with upstream: 0 (0.00%) Number of commits in upstream but not in rpm: 280717 Number of commits NOT found in upstream: 3 (100.00%)

Rebuilding Kernel on Branch rocky9_5_rebuild_kernel-5.14.0-503.23.1.el9_5 for kernel-5.14.0-503.23.1.el9_5 Clean Cherry Picks: 0 (0.00%)
Empty Cherry Picks: 0 (0.00%)
_______________________________

Full Details Located here:
ciq/ciq_backports/kernel-5.14.0-503.23.1.el9_5/rebuild.details.txt

Includes:
* git commit header above
* Empty Commits with upstream SHA
* RPM ChangeLog Entries that could not be matched

Individual Empty Commit failures contained in the same containing directory. The git message for empty commits will have the path for the failed commit. File names are the first 8 characters of the upstream SHA

Change is burried in the splat

printk: nbcon: Fix illegal RCU usage on thread wakeup (Derek Barbosa) [RHEL-73036]
This might be a RHEL only fix at the moment.

diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
index b941039ee7d2..b4278854eeb9 100644
--- a/kernel/printk/nbcon.c
+++ b/kernel/printk/nbcon.c
@@ -1101,9 +1101,6 @@ static void nbcon_irq_work(struct irq_work *irq_work)

 static inline bool rcuwait_has_sleeper(struct rcuwait *w)
 {
-       bool has_sleeper;
-
-       rcu_read_lock();
        /*
         * Guarantee any new records can be seen by tasks preparing to wait
         * before this context checks if the rcuwait is empty.
@@ -1116,10 +1113,7 @@ static inline bool rcuwait_has_sleeper(struct rcuwait *w)
         * This pairs with nbcon_kthread_func:A.
         */
        smp_mb(); /* LMM(rcuwait_has_sleeper:A) */
-       has_sleeper = !!rcu_dereference(w->task);
-       rcu_read_unlock();
-
-       return has_sleeper;
+       return rcuwait_active(w);
 }

BUILD

[maple@r9-sigcloud-builder kernel-src-tree]$ ../kernel-src-tree-tools/kernel_build.sh
/mnt/code/kernel-src-tree
no .config file found, moving on
[TIMER]{MRPROPER}: 0s
x86_64 architecture detected, copying config
'configs/kernel-5.14.0-x86_64.config' -> '.config'
Setting Local Version for build
CONFIG_LOCALVERSION="-rocky9_5_rebuild"
Making olddefconfig
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
Starting Build
  SYNC    include/config/auto.conf.cmd
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_32.h
  SYSHDR  arch/x86/include/generated/uapi/asm/unistd_64.h

[SNIP]

  BTF [M] sound/x86/snd-hdmi-lpe-audio.ko
  BTF [M] sound/virtio/virtio_snd.ko
  BTF [M] sound/xen/snd_xen_front.ko
[TIMER]{BUILD}: 1659s
Making Modules
  INSTALL /lib/modules/5.14.0-rocky9_5_rebuild/kernel/arch/x86/crypto/blake2s-x86_64.ko
  STRIP   /lib/modules/5.14.0-rocky9_5_rebuild/kernel/arch/x86/crypto/blake2s-x86_64.ko
  SIGN    /lib/modules/5.14.0-rocky9_5_rebuild/kernel/arch/x86/crypto/blake2s-x86_64.ko

[SNIP]

  STRIP   /lib/modules/5.14.0-rocky9_5_rebuild/kernel/sound/xen/snd_xen_front.ko
  SIGN    /lib/modules/5.14.0-rocky9_5_rebuild/kernel/sound/xen/snd_xen_front.ko
  DEPMOD  /lib/modules/5.14.0-rocky9_5_rebuild
[TIMER]{MODULES}: 40s
Making Install
sh ./arch/x86/boot/install.sh 5.14.0-rocky9_5_rebuild \
	arch/x86/boot/bzImage System.map "/boot"
[TIMER]{INSTALL}: 42s
Checking kABI
kABI check passed
Setting Default Kernel to /boot/vmlinuz-5.14.0-rocky9_5_rebuild and Index to 2
The default is /boot/loader/entries/7fa7fd342df64eb3a21101f853852c27-5.14.0-rocky9_5_rebuild.conf with index 2 and kernel /boot/vmlinuz-5.14.0-rocky9_5_rebuild
The default is /boot/loader/entries/7fa7fd342df64eb3a21101f853852c27-5.14.0-rocky9_5_rebuild.conf with index 2 and kernel /boot/vmlinuz-5.14.0-rocky9_5_rebuild
Generating grub configuration file ...
Adding boot menu entry for UEFI Firmware Settings ...
done
Hopefully Grub2.0 took everything ... rebooting after time metrices
[TIMER]{MRPROPER}: 0s
[TIMER]{BUILD}: 1659s
[TIMER]{MODULES}: 40s
[TIMER]{INSTALL}: 42s
[TIMER]{TOTAL} 1744s
Rebooting in 10 seconds
[maple@r9-sigcloud-builder kernel-src-tree]$

##Testing
Just did a single pass
Screenshot 2025-02-11 at 6 21 29 PM

Rebuild_History BUILDABLE
Rebuilding Kernel from rpm changelog with Fuzz Limit: 87.50%
Number of commits in upstream range v5.14~1..master: 280717
Number of commits in rpm: 3
Number of commits matched with upstream: 0 (0.00%)
Number of commits in upstream but not in rpm: 280717
Number of commits NOT found in upstream: 3 (100.00%)

Rebuilding Kernel on Branch rocky9_5_rebuild_kernel-5.14.0-503.23.1.el9_5 for kernel-5.14.0-503.23.1.el9_5
Clean Cherry Picks: 0 (0.00%)
Empty Cherry Picks: 0 (0.00%)
_______________________________

Full Details Located here:
ciq/ciq_backports/kernel-5.14.0-503.23.1.el9_5/rebuild.details.txt

Includes:
* git commit header above
* Empty Commits with upstream SHA
* RPM ChangeLog Entries that could not be matched

Individual Empty Commit failures contained in the same containing directory.
The git message for empty commits will have the path for the failed commit.
File names are the first 8 characters of the upstream SHA
@PlaidCat PlaidCat self-assigned this Feb 11, 2025
Copy link

@gvrose8192 gvrose8192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon completion of all kernel build jobs I'll approve - if there's any build failures in CI then consider my approval withdrawn. But LGTM - Thanks!

Copy link
Collaborator

@bmastbergen bmastbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥌

@PlaidCat PlaidCat merged commit 5fee719 into rocky9_5 Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants