-
Notifications
You must be signed in to change notification settings - Fork 10
[rocky8_10] History rebuild for kernel-4.18.0-553.54.1.el8_10 #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jira NONE_AUTOMATION cve CVE-2024-43842 Rebuild_History Non-Buildable kernel-4.18.0-553.54.1.el8_10 commit-author Aleksandr Mishin <[email protected]> commit 85099c7 In rtw89_sta_info_get_iter() 'status->he_gi' is compared to array size. But then 'rate->he_gi' is used as array index instead of 'status->he_gi'. This can lead to go beyond array boundaries in case of 'rate->he_gi' is not equal to 'status->he_gi' and is bigger than array size. Looks like "copy-paste" mistake. Fix this mistake by replacing 'rate->he_gi' with 'status->he_gi'. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e3ec701 ("rtw89: add Realtek 802.11ax driver") Signed-off-by: Aleksandr Mishin <[email protected]> Signed-off-by: Ping-Ke Shih <[email protected]> Link: https://patch.msgid.link/[email protected] (cherry picked from commit 85099c7) Signed-off-by: Jonathan Maple <[email protected]>
jira NONE_AUTOMATION Rebuild_History Non-Buildable kernel-4.18.0-553.54.1.el8_10 commit-author Przemek Kitszel <[email protected]> commit 257310e Simplify stats accumulation logic to fix the case where we don't take previous stat value into account, we should always respect it. Main netdev stats of our PF (Tx/Rx packets/bytes) were reported orders of magnitude too big during OpenStack reconfiguration events, possibly other reconfiguration cases too. The regression was reported to be between 6.1 and 6.2, so I was almost certain that on of the two "preserve stats over reset" commits were the culprit. While reading the code, it was found that in some cases we will increase the stats by arbitrarily large number (thanks to ignoring "-prev" part of condition, after zeroing it). Note that this fixes also the case where we were around limits of u64, but that was not the regression reported. Full disclosure: I remember suggesting this particular piece of code to Ben a few years ago, so blame on me. Fixes: 2fd5e43 ("ice: Accumulate HW and Netdev statistics over reset") Reported-by: Nebojsa Stevanovic <[email protected]> Link: https://lore.kernel.org/intel-wired-lan/VI1PR02MB439744DEDAA7B59B9A2833FE912EA@VI1PR02MB4397.eurprd02.prod.outlook.com Reported-by: Christian Rohmann <[email protected]> Link: https://lore.kernel.org/intel-wired-lan/[email protected] Reviewed-by: Jacob Keller <[email protected]> Signed-off-by: Przemek Kitszel <[email protected]> Reviewed-by: Simon Horman <[email protected]> Tested-by: Pucha Himasekhar Reddy <[email protected]> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <[email protected]> (cherry picked from commit 257310e) Signed-off-by: Jonathan Maple <[email protected]>
Rebuild_History BUILDABLE Rebuilding Kernel from rpm changelog with Fuzz Limit: 87.50% Number of commits in upstream range v4.18~1..kernel-mainline: 540031 Number of commits in rpm: 9 Number of commits matched with upstream: 2 (22.22%) Number of commits in upstream but not in rpm: 540029 Number of commits NOT found in upstream: 7 (77.78%) Rebuilding Kernel on Branch rocky8_10_rebuild_kernel-4.18.0-553.54.1.el8_10 for kernel-4.18.0-553.54.1.el8_10 Clean Cherry Picks: 2 (100.00%) Empty Cherry Picks: 0 (0.00%) _______________________________ Full Details Located here: ciq/ciq_backports/kernel-4.18.0-553.54.1.el8_10/rebuild.details.txt Includes: * git commit header above * Empty Commits with upstream SHA * RPM ChangeLog Entries that could not be matched Individual Empty Commit failures contained in the same containing directory. The git message for empty commits will have the path for the failed commit. File names are the first 8 characters of the upstream SHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚤
@PlaidCat, It looks like we're deleting the configs again. Is that expected? |
The CI passes because we do have config files. I think we are removing files with the version suffix. I don't know why. Maple can answer that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥌
The non-versioned ones are the actual ones we need, there are a lot of You as @thefossguy-ciq said the configs are there that we want because the CI ran, but the versioned configs come from the SOURCES/ but the non-versioned ones are the ones that actually ran through Additionally this program has only had slight updates since the initial "CoPilot and redbull` |
General Process:
src.rpm
4.18.0-553
git cherry-pick
rpmbuild -bp
from corresponding src.rpm.Checking Rebuild Commits for Potentially missing commits:
kernel-4.18.0-553.54.1
Build
KSelfTests