[fips 9.2] netfilter: nf_tables: skip bound chain on rule flush #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jira VULN-8826 cve CVE-2023-3777 commit-author Pablo Neira Ayuso <[email protected]> commit 6eaf41e Skip bound chain when flushing table rules, the rule that owns this chain releases these objects. Otherwise, the following warning is triggered: WARNING: CPU: 2 PID: 1217 at net/netfilter/nf_tables_api.c:2013 nf_tables_chain_destroy+0x1f7/0x210 [nf_tables] CPU: 2 PID: 1217 Comm: chain-flush Not tainted 6.1.39 #1 RIP: 0010:nf_tables_chain_destroy+0x1f7/0x210 [nf_tables] Fixes: d0e2c7d ("netfilter: nf_tables: add NFT_CHAIN_BINDING") Reported-by: Kevin Rich <[email protected]> Signed-off-by: Pablo Neira Ayuso <[email protected]> Signed-off-by: Florian Westphal <[email protected]> (cherry picked from commit 6eaf41e) Signed-off-by: Anmol Jain <[email protected]>
jainanmol84
requested review from
PlaidCat,
bmastbergen,
Copilot,
shreeya-patel98 and
thefossguy-ciq
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a security vulnerability (CVE-2023-3777) in the netfilter nf_tables subsystem by preventing bound chains from being processed during rule flush operations. The fix addresses a warning that occurs when the table flush operation attempts to handle bound chains, which should be managed by their owning rules instead.
- Adds a check to skip bound chains during rule flush operations
- Prevents improper destruction of bound chain objects that are owned by rules
|
@jainanmol84 please refrain from adding copilot as a reviewer in the future. It isn't necessary since we are backporting the commits as-is (or as close as possible when merge conflicts are encountered). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message
Kernel build logs
kernel-build.log
Kselftests
kselftest-after.log
kselftest-before.log