fix: Fix adding missing columns for ORDER BY clause
#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Qyoun-ae <[email protected]>
ovr
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with
ORDER BYclause adding missing columns in an incorrect way. Issues fixed:LogicalPlanBuilder::sortcould add duplicate columns.LogicalPlanBuilder::add_missing_columnsdid not recognize that the inputs could already have unqualified aliasrewrite_sort_col_by_aggsunnormalized columns before normalizing them back; this would yield incorrect qualifierextract_aliased_expr_namesdid not extract column names for aliased projections