feat: add support for arbitrary CSS function syntax in container queries#1028
Merged
feat: add support for arbitrary CSS function syntax in container queries#1028
Conversation
- Add 'raw' subtype to ContainerCondition for verbatim CSS passthrough - Support functions like scroll-state() and style() in @(...) queries - Fix parentheses-aware comma splitting for functions with inner commas - Update tokenizer regex to handle nested parentheses in container queries - Add comprehensive tests for parsing and rendering - Update documentation with examples and usage notes Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: fd5770f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-e56aadb. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core state parsing and
@containerrule generation; regressions could affect container query handling and condition deduplication/combination, though changes are scoped and covered by new tests.Overview
Enables raw CSS function-like conditions inside
@(...)container queries (e.g.@(scroll-state(...)),@(nav, scroll-state(...)),@(style(display: flex))) by parsing them as a newcontainercondition subtype and emitting them verbatim in generated@containerrules.Updates parsing to be parentheses-aware when splitting
@(name, condition)(so commas inside function args don’t break parsing), extends condition IDs/caching to include raw conditions, and adds coverage in pipeline/state/output tests plus docs/changeset clarifying that$...style-query shorthand remains the recommended approach for custom properties.Written by Cursor Bugbot for commit fd5770f. This will update automatically on new commits. Configure here.