Skip to content

fix(ResizablePanel): props propagation #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(ResizablePanel): props propagation #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-ladybugs-mate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cube-dev/ui-kit': patch
---

Fix props propagation in ResizablePanel.
7 changes: 4 additions & 3 deletions src/components/layout/ResizablePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ const Handler = (props: HandlerProps) => {
);
};

const PanelElement = tasty(Panel, {
const StyledPanel = tasty(Panel, {
styles: {
flexGrow: 0,
width: {
Expand Down Expand Up @@ -220,6 +220,7 @@ function ResizablePanel(
onSizeChange,
minSize = 200,
maxSize = isControllable ? undefined : 'min(50%, 400px)',
...restProps
} = props;

const [isDragging, setIsDragging] = useState(false);
Expand Down Expand Up @@ -330,7 +331,7 @@ function ResizablePanel(
}, [isDragging, isHorizontal, isDisabled]);

return (
<PanelElement
<StyledPanel
ref={ref}
data-direction={direction}
mods={mods}
Expand All @@ -342,7 +343,7 @@ function ResizablePanel(
mods={mods}
/>
}
{...mergeProps(props, {
{...mergeProps(restProps, {
style: {
// We set a current size further via width/min-width/max-width styles to respect size boundaries
'--size': `${size}px`,
Expand Down
Loading