Skip to content

fix: version define #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix: version define #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-yaks-fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@cube-dev/ui-kit': patch
---

Check the env before setting uikit version globally.
24 changes: 13 additions & 11 deletions src/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,19 @@ interface Window {
};
}

const version = '__UIKIT_VERSION__';
if (typeof window !== 'undefined') {
const version = '__UIKIT_VERSION__';

// Ensure CubeUIKit is defined on window in a way bundlers recognize
window.CubeUIKit = window.CubeUIKit || { version };
// Ensure CubeUIKit is defined on window in a way bundlers recognize
window.CubeUIKit = window.CubeUIKit || { version };

// Check for multiple versions
if (window.CubeUIKit.version && window.CubeUIKit.version !== version) {
console.error('More than one version of CubeUIKit is loaded', {
loadedVersions: [window.CubeUIKit.version, version],
});
} else {
// Set version if not already set
window.CubeUIKit.version = version;
// Check for multiple versions
if (window.CubeUIKit.version && window.CubeUIKit.version !== version) {
console.error('More than one version of CubeUIKit is loaded', {
loadedVersions: [window.CubeUIKit.version, version],
});
} else {
// Set version if not already set
window.CubeUIKit.version = version;
}
}
Loading