Skip to content

fix(ResizablePanel): drift in controllable state #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

fix(ResizablePanel): drift in controllable state #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74df17f
fix(ResizablePanel): drift in controllable state
tenphi May 6, 2025
40be2fa
fix(ResizablePanel): drift in controllable state * 2
tenphi May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gold-flies-flow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Fix drift in Resizable Panel in controllable state.
8 changes: 4 additions & 4 deletions src/components/layout/ResizablePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ function ResizablePanel(
},
});

// Since we sync provided size and the local one in two ways
// Since we sync provided size and the local one in two ways,
// we need a way to prevent infinite loop in some cases.
// We will run this in setTimeout and make sure it will get the most recent state.
const notifyChange = useEvent(() => {
Expand Down Expand Up @@ -329,7 +329,7 @@ function ResizablePanel(
}, [visualSize, isDragging]);

useEffect(() => {
setTimeout(notifyChange);
requestIdleCallback(notifyChange);
}, [providedSize]);

const mods = useMemo(() => {
Expand All @@ -355,9 +355,9 @@ function ResizablePanel(
}
{...mergeProps(restProps, {
style: {
// We set a current size further via width/min-width/max-width styles to respect size boundaries
// We set the current size further via width/min-width/max-width styles to respect size boundaries
'--size': `${size}px`,
// We use a separate visual size to paint the handler for smoother experience
// We use a separate visual size to paint the handler for a smoother experience
'--visual-size': `${visualSize}px`,
'--min-size': typeof minSize === 'number' ? `${minSize}px` : minSize,
'--max-size': typeof maxSize === 'number' ? `${maxSize}px` : maxSize,
Expand Down
Loading