Skip to content

Conversation

@tenphi
Copy link
Member

@tenphi tenphi commented Jun 6, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2025

🦋 Changeset detected

Latest commit: fa70375

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 8:28am

@netlify
Copy link

netlify bot commented Jun 6, 2025

Deploy Preview for cube-uikit-docs failed.

Name Link
🔨 Latest commit fa70375
🔍 Latest deploy log https://app.netlify.com/projects/cube-uikit-docs/deploys/6842a66ab439e8000842eb2a

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-215df3c.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the PrismCode component to accept nullish code values and normalize them to an empty string.

  • Adjust destructuring and add a nullish check for code
  • Include a changeset entry documenting the new behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/components/content/PrismCode/PrismCode.tsx Allow code prop to be null/undefined by normalizing to ''
.changeset/fair-cycles-design.md Document patch release for nullish support
Comments suppressed due to low confidence (2)

src/components/content/PrismCode/PrismCode.tsx:85

  • Add unit tests to verify that PrismCode correctly handles null and undefined for the code prop to prevent regressions.
if (!code) {

src/components/content/PrismCode/PrismCode.tsx:89

  • Update the component's documentation or TypeScript definitions to indicate that code can be nullish and will be normalized to an empty string.
if (typeof code !== 'string' && code) {

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

🏗 Docs are successfully deployed!

👀 Preview: https://6842a6b3b309c078e50ebbde--cube-uikit-docs.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

🏋️ Size limit report

Name Size Passed?
All 252.28 KB (+0.01% 🔺) Yes 🎉
Tree shaking (just a Button) 21.71 KB (0% 🟰) Yes 🎉
Tree shaking (just an Icon) 11.4 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

@tenphi tenphi merged commit 9b52be6 into main Jun 6, 2025
13 of 17 checks passed
@tenphi tenphi deleted the fix-prism-code-empty branch June 6, 2025 08:53
@github-actions github-actions bot mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants