Skip to content

Conversation

@tenphi
Copy link
Member

@tenphi tenphi commented Jul 7, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: 82867fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jul 7, 2025

Deploy Preview for cube-uikit-docs failed.

Name Link
🔨 Latest commit 82867fb
🔍 Latest deploy log https://app.netlify.com/projects/cube-uikit-docs/deploys/686d3609e6d1d60008065195

@vercel
Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cube-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 3:18pm
cube-ui-kit-cursor ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 3:18pm

@tenphi tenphi requested a review from Copilot July 7, 2025 12:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

📦 NPM canary release

Deployed canary version 0.0.0-canary-244457d.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🏗 Docs are successfully deployed!

👀 Preview: https://686d1efbab284cbc0bd8abae--cube-uikit-docs.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025

🏋️ Size limit report

Name Size Passed?
All 258.97 KB (+1.1% 🔺) No 👎
Tree shaking (just a Button) 21.71 KB (-0.01% 🔽👏) Yes 🎉
Tree shaking (just an Icon) 11.4 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the ListBox component by introducing a customizable empty-state label, refactoring search filtering to use React Stately’s built-in API, and improving keyboard navigation support. Tests, stories, and documentation are updated to reflect these changes.

  • Added emptyLabel prop for customizing the “No results found” message
  • Replaced manual filtering logic with a collectionFilter callback for React Stately
  • Improved keyboard navigation handling and updated associated tests, stories, and docs

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/components/fields/ListBox/ListBox.tsx Implement emptyLabel, refactor filtering, and update keyboard handling
src/components/fields/ListBox/ListBox.test.tsx Added tests for keyboard navigation and focus handling
src/components/fields/ListBox/ListBox.stories.tsx Added stories for autofocus and custom empty label
src/components/fields/ListBox/ListBox.docs.mdx Documented emptyLabel and example usage
.changeset/shiny-mangos-double.md Changeset describing new empty-state support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants