Skip to content

feat(ItemBase) add generic item component #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Aug 15, 2025
Merged
Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
ef12d36
feat(ItemBase): add component
tenphi Aug 8, 2025
367252a
feat(Item): add generic item component
tenphi Aug 8, 2025
95a9b1e
feat(ItemButton): add component
tenphi Aug 12, 2025
c979df5
feat(ItemBase): land hotkeys and tooltip features here
tenphi Aug 12, 2025
5928189
fix(Menu): migrate to BaseItem for items
tenphi Aug 12, 2025
524d226
fix(ListBox): migrate to ItemBase
tenphi Aug 12, 2025
72e5b21
fix(useAnchoredMenu): api
tenphi Aug 13, 2025
517f9c4
fix(FilterPicker): migrate the trigger to ItemButton
tenphi Aug 13, 2025
5c3cbbe
fix(FilterPicker): search input size
tenphi Aug 13, 2025
5e05dc8
fix(Menu): item li tag
tenphi Aug 13, 2025
cf8b834
Merge remote-tracking branch 'origin' into feat-item-base
tenphi Aug 13, 2025
69256e8
chore: upgrade storybook
tenphi Aug 13, 2025
3ffc286
chore: upgrade storybook
tenphi Aug 13, 2025
48a00f7
fix(CommandMenu): search input styles
tenphi Aug 13, 2025
7fd7189
chore: add changelog
tenphi Aug 13, 2025
7ab1057
fix(ItemBase): styles and itemcontent condition
tenphi Aug 13, 2025
f828c09
fix(ItemBase): vertical size
tenphi Aug 13, 2025
6aa2864
fix(item-themes): update colors
tenphi Aug 13, 2025
c156acf
fix: section heading paddings
tenphi Aug 13, 2025
3fb9f19
fix(ItemBase): small size height
tenphi Aug 13, 2025
4b0d18b
fix(ItemBase): small size height * 2
tenphi Aug 13, 2025
18f297b
fix(ListBox): isSelected passing
tenphi Aug 13, 2025
4700c24
fix(Select): placeholder opacity
tenphi Aug 13, 2025
8fb3dd0
chore: update tsconfig
tenphi Aug 13, 2025
b4ce299
fix(Menu): remove duplicated hotkey
tenphi Aug 13, 2025
9f0dd8c
fix: item themes
tenphi Aug 13, 2025
a34d165
fix(ItemBase): support description block
tenphi Aug 14, 2025
8afd205
fix(ItemBase): change descriptionPlacement api
tenphi Aug 14, 2025
68b1674
fix(ItemBase): first attempt on tooltip support
tenphi Aug 14, 2025
043f6cd
fix(ItemBase): full tooltip support
tenphi Aug 14, 2025
af42adc
fix: migrate select and filter picker to all item base props
tenphi Aug 14, 2025
2a58bd5
chore: update documentation
tenphi Aug 14, 2025
7ce10ab
feat(FilterListBox): props for additional option customization
tenphi Aug 15, 2025
45e23c9
chore: fix documentation
tenphi Aug 15, 2025
784d61c
fix(FilterPicker): trigger open sync
tenphi Aug 15, 2025
42a1371
chore: rename data-menu-trigger to data-popover-trigger
tenphi Aug 15, 2025
c614f8c
fix(ItemBase): description padding
tenphi Aug 15, 2025
b4f5d6d
fix(ItemBase): description padding * 2
tenphi Aug 15, 2025
043e9f7
fix(Section): padding styles
tenphi Aug 15, 2025
0c9702e
fix(Section): padding styles * 2
tenphi Aug 15, 2025
33019ff
fix(Section): padding styles * 3
tenphi Aug 15, 2025
eedb52f
chore: add changelog
tenphi Aug 15, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/beige-cameras-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Make menu props optional for open method in `useAnchoredMenu`.
5 changes: 5 additions & 0 deletions .changeset/clean-carrots-flash.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Increase search input size for FilterListBox and CommandMenu.
5 changes: 5 additions & 0 deletions .changeset/gentle-timers-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Add default menu props to `useAnchoredMenu`.
5 changes: 5 additions & 0 deletions .changeset/happy-cycles-pretend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Add `allValueProps`, `customValueProps` and `newCustomValueProps` to customize the additional options in ListBox, FilterListBox and FilterPicker.
5 changes: 5 additions & 0 deletions .changeset/tricky-carpets-laugh.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cube-dev/ui-kit": patch
---

Sync opening state between FilterPicker instances and other triggers.
2 changes: 1 addition & 1 deletion .size-limit.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = [
}),
);
},
limit: '284kB',
limit: '285kB',
},
{
name: 'Tree shaking (just a Button)',
Expand Down
7 changes: 0 additions & 7 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// @ts-check
import remarkGfm from 'remark-gfm';

/** @type {import('@storybook/core-common').StorybookConfig} */
const config = {
staticDirs: ['../public'],

Expand All @@ -23,8 +22,6 @@ const config = {

addons: [
'@storybook/addon-links',
'@storybook/addon-essentials',
'@storybook/addon-interactions',
{
name: 'storybook-addon-turbo-build',
options: {
Expand All @@ -44,9 +41,5 @@ const config = {
},
},
],

docs: {
autodocs: true,
},
};
export default config;
12 changes: 3 additions & 9 deletions .storybook/preview.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DocsContainer } from '@storybook/addon-docs';
import { configure } from '@storybook/test';
import isChromatic from 'chromatic/isChromatic';
import { config } from 'react-transition-group';
import { configure } from 'storybook/test';

import { Root } from '../src';

Expand Down Expand Up @@ -37,13 +36,7 @@ export const parameters = {
return aTitle.localeCompare(bTitle, undefined, { numeric: true });
},
},
docs: {
container: ({ children, context }) => (
<DocsContainer context={context}>
<Root fontDisplay="auto">{children}</Root>
</DocsContainer>
),
},
docs: {},
backgrounds: {
default: 'transparent',
values: [
Expand All @@ -64,3 +57,4 @@ export const decorators = [
</Root>
),
];
export const tags = ['autodocs'];
19 changes: 6 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"fix": "npm-run-all -p eslint:fix prettier:fix",
"storybook": "STORYBOOK_MODE=stories storybook dev -p 6060",
"build-storybook": "STORYBOOK_MODE=stories storybook build",
"build-docs": "STORYBOOK_MODE=docs storybook build --docs -o storybook-docs",
"build-docs": "storybook build -o storybook-docs",
"build-static-docs": "npm run build-docs && node scripts/snapshot-docs.js",
"size": "size-limit",
"prepare": "husky install",
Expand Down Expand Up @@ -115,16 +115,9 @@
"@size-limit/webpack": "^8.2.4",
"@size-limit/webpack-why": "^8.2.4",
"@statoscope/cli": "^5.20.1",
"@storybook/addon-actions": "^8.6.12",
"@storybook/addon-docs": "^8.6.12",
"@storybook/addon-essentials": "^8.6.12",
"@storybook/addon-interactions": "^8.6.12",
"@storybook/addon-links": "^8.6.12",
"@storybook/addon-mdx-gfm": "^8.6.12",
"@storybook/blocks": "^8.6.12",
"@storybook/react": "^8.6.12",
"@storybook/react-vite": "^8.6.12",
"@storybook/test": "^8.6.12",
"@storybook/addon-docs": "^9.1.2",
"@storybook/addon-links": "^9.1.2",
"@storybook/react-vite": "^9.1.2",
"@swc/core": "^1.3.36",
"@swc/jest": "^0.2.36",
"@testing-library/dom": "^9.3.4",
Expand Down Expand Up @@ -153,7 +146,7 @@
"eslint-plugin-jsx-a11y": "^6.10.2",
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-react-hooks": "^5.2.0",
"eslint-plugin-storybook": "^0.12.0",
"eslint-plugin-storybook": "^9.1.2",
"husky": "^6.0.0",
"jest": "^29.7.0",
"jest-environment-jsdom": "^29.7.0",
Expand All @@ -170,7 +163,7 @@
"react-test-renderer": "^18.2.0",
"rimraf": "^6.0.1",
"size-limit": "^8.2.6",
"storybook": "^8.6.12",
"storybook": "^9.1.2",
"storybook-addon-turbo-build": "^2.0.1",
"styled-components": "^6.1.8",
"swc-loader": "^0.2.6",
Expand Down
Loading
Loading