Skip to content

Conversation

@tenphi
Copy link
Member

@tenphi tenphi commented Sep 10, 2025

Describe changes

Checklist

Before taking this PR from the draft, please, make sure you have done the following:

  • Pipeline is passed
  • Tests are added (including unit tests and stories in the storybook)
  • Tests are passed successfully
  • If you're adding a new component/new props, add stories that describe how this component/prop works
  • Changeset(s) is(are) added
  • You have passed the threshold of the library size
  • Commit message follows commit guidelines

Closes: N/A

Other information

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025

🦋 Changeset detected

Latest commit: 369f932

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cube-dev/ui-kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
cube-ui-kit Ready Ready Preview Comment Sep 10, 2025 7:53am
cube-ui-kit-cursor Ready Ready Preview Comment Sep 10, 2025 7:53am

@github-actions
Copy link
Contributor

📦 NPM canary release

Deployed canary version 0.0.0-canary-a3d6f58.

@github-actions
Copy link
Contributor

🧪 Storybook is successfully deployed!

@github-actions
Copy link
Contributor

🏋️ Size limit report

Name Size Passed?
All 297.59 KB (+0.01% 🔺) Yes 🎉
Tree shaking (just a Button) 31.46 KB (0% 🟰) Yes 🎉
Tree shaking (just an Icon) 19.35 KB (0% 🟰) Yes 🎉

Click here if you want to find out what is changed in this build

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes tooltip logic in the ItemBase component by improving the conditions for auto tooltip display and allowing tooltip title to be overridden.

  • Refines auto tooltip conditions to only enable when children is a string
  • Removes redundant string type check in useEffect since it's handled upstream
  • Allows tooltip title to be customized through tooltipProps.title

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/components/content/ItemBase/ItemBase.tsx Updates tooltip logic conditions and allows title override
.changeset/khaki-kids-care.md Documents tooltip title rewrite feature
.changeset/beige-readers-relate.md Documents tooltip condition fix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tenphi tenphi merged commit 39be6b6 into main Sep 10, 2025
14 checks passed
@tenphi tenphi deleted the fix-item-base-tooltip branch September 10, 2025 08:23
@github-actions github-actions bot mentioned this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants