-
Notifications
You must be signed in to change notification settings - Fork 6
fix(ItemBase): tooltip logic #784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 369f932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📦 NPM canary releaseDeployed canary version 0.0.0-canary-a3d6f58. |
🧪 Storybook is successfully deployed!
|
🏋️ Size limit report
Click here if you want to find out what is changed in this build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes tooltip logic in the ItemBase component by improving the conditions for auto tooltip display and allowing tooltip title to be overridden.
- Refines auto tooltip conditions to only enable when children is a string
- Removes redundant string type check in useEffect since it's handled upstream
- Allows tooltip title to be customized through tooltipProps.title
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/content/ItemBase/ItemBase.tsx | Updates tooltip logic conditions and allows title override |
| .changeset/khaki-kids-care.md | Documents tooltip title rewrite feature |
| .changeset/beige-readers-relate.md | Documents tooltip condition fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Describe changes
Checklist
Before taking this PR from the draft, please, make sure you have done the following:
Closes: N/A
Other information